Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests/spec/fs.readlink.spec.js to use const, let and strict mode #660

Closed
yuansheng1989 opened this Issue Jan 23, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@yuansheng1989
Copy link
Contributor

yuansheng1989 commented Jan 23, 2019

fs.readlink.spec.js is using var. It should be replaced by let or const in strict mode.

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Jan 23, 2019

Sounds good @yuansheng1989, it's all yours.

humphd added a commit that referenced this issue Jan 31, 2019

Fix issue #660: Updated the code to replace var with let, const in st…
…rict mode (#694)

* Modify the test file to fix issue-660

* change let to const
@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Jan 31, 2019

NOTE: when you do a PR, you can tell GitHub to automatically close the associated issue by using "Fixes #660" in your PR description.

@humphd humphd closed this Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.