Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "filer/tests/spec/fs.readdir.spec.js" to use let/const instead of var #667

Closed
jatinkumarg opened this Issue Jan 24, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@jatinkumarg
Copy link
Contributor

jatinkumarg commented Jan 24, 2019

I just noticed that "fs.readdir.spec.js" contains lots of var declared variables. Can I get the authorization to update the required variables to use const or let instead of using var?

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Jan 24, 2019

Go ahead @jatinkumarg, it's all yours.

@humphd humphd closed this in 0380a81 Jan 31, 2019

humphd added a commit that referenced this issue Feb 2, 2019

fixes issue #667 (#678)
* fixes issue 667: Update code in tests/some/fs.write.spec.js to use const/let AND strict mode

* fixes issue 667: Update code in tests/some/fs.write.spec.js to use const/let AND strict mode

* changed let to const for variables pointing to required function

* switched a few variable lets to const in file fs.write.spec.js

* switched a few variable lets to const in file fs.write.spec.js

* added package-lock.json file

* changed variables let to const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.