Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ' filer/src/shell/environment.js' file to use const/let instead of var #698

Closed
pbrahmbhatt3 opened this Issue Jan 29, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@pbrahmbhatt3
Copy link
Contributor

pbrahmbhatt3 commented Jan 29, 2019

The file 'filer/src/shell/environment.js' has variables that are constants and are declared using var. It has to be updated by using const instead.

@pbrahmbhatt3

This comment has been minimized.

Copy link
Contributor Author

pbrahmbhatt3 commented Jan 29, 2019

Hi @humphd, just wanted to make sure if I can go for it in case no one is working on it?

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Jan 29, 2019

@pbrahmbhatt3 this is a huge file, you sure you want to do it? You'll need to do it throughout the entire file. If that's OK, go for it. But also, feel free to grab a smaller file if you want.

@pbrahmbhatt3 pbrahmbhatt3 changed the title Update ' filer/src/filesystem/implementation.js ' file to use const/let instead of var Update ' filer/src/shell/environment.js' file to use const/let instead of var Jan 29, 2019

@pbrahmbhatt3

This comment has been minimized.

Copy link
Contributor Author

pbrahmbhatt3 commented Jan 29, 2019

I have taken a new file now. Is it okay? @humphd

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Jan 31, 2019

You can tell GitHub to automatically close an issue when a PR is merged by adding "Fixes #698" in the PR's description.

@humphd humphd closed this Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.