Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #419: Add test for fsPromises.open() when the path does not exist #455

Merged
merged 4 commits into from Oct 9, 2018

Conversation

Projects
None yet
4 participants
@struong9
Copy link
Contributor

commented Sep 23, 2018

Added a test for fsPromises.open() when the path doesn't exist

Show resolved Hide resolved tests/spec/fs.open.spec.js Outdated
Show resolved Hide resolved package.json Outdated
@ooHAoo
Copy link
Contributor

left a comment

Nicely done! Code looks precise and especially with the use of promises! (we don't see too many of it - always nice to see more)
Just a few suggestions I have received and would like to pass on to you :)

Show resolved Hide resolved tests/spec/fs.open.spec.js Outdated
Show resolved Hide resolved tests/spec/fs.open.spec.js Outdated
Show resolved Hide resolved tests/spec/fs.open.spec.js Outdated
Fix #419: Add test for fsPromises.open() when the path does not exist
Removed some unnecessary code based on reviews
@humphd
Copy link
Contributor

left a comment

Please make the change that @ooHAoo suggested 15 days ago: you need to return the result of your fsPromises.open() call.

@humphd

humphd approved these changes Oct 9, 2018

@humphd humphd merged commit 934ef8b into filerjs:master Oct 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@humphd

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2018

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.