Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a test for promises version of fs.unlink() #468

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@mphan6
Copy link

commented Sep 24, 2018

Created a promises version test for fs.Unlink().

Resolves issue: #444

if (error) throw error;
});
});
});

This comment has been minimized.

Copy link
@SeanPrashad

SeanPrashad Sep 25, 2018

Contributor

Hey @mphan6 - nice job here 👏 ! Just one tiny nitpick - GitHub is telling us that you didn't add a blank line at the end of the file with the image icon.

Can you amend that to your existing commit then force push again? Let me know if you need any help with that!

Added space
Added the space suggested by Sean
@SeanPrashad
Copy link
Contributor

left a comment

Thanks for the fix - this looks good! :shipit:

@humphd

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2018

It looks @jagmeetb has also done basically the same test. We should discuss how to proceed, and which to land.

Also, this code has a merge conflict with what's on master. Let's talk about how to fix this in class this week.

@humphd

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2018

I've landed essentially the same code as this in 1abcb03, closing as dupe.

@humphd humphd closed this Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.