New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce newline at end of files #498

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@0xazure
Contributor

0xazure commented Sep 24, 2018

Trailing newlines are a common idiom in programming, and enabling this rule will save reviewers nitpicking or overlooking missing trailing newlines.

ESLint also supports the --fix option to automate fixing some of the problems reported by this rule.

There are no current files in the codebase that require fixing to add trailing newlines as verified by npm run lint.

Enforce newline at end of files
Trailing newlines are a common idiom in
programming, and enabling this rule will save
reviewers nitpicking or overlooking missing
trailing newlines.

ESLint also supports the `--fix` option to
automate fixing some of the problems reported by
this rule.

There are no current files in the codebase that
require fixing to add trailing newlines as
verified by `npm run lint`.
@0xazure

This comment has been minimized.

Contributor

0xazure commented Sep 24, 2018

To consider:

This rule enforces at least one newline (or absence thereof) at the end of non-empty files.

If we want to enforce just one trailing newline, we would also need to enable no-multiple-empty-lines to control maxEOF.

@humphd humphd requested a review from modeswitch Sep 25, 2018

@humphd

This comment has been minimized.

Contributor

humphd commented Sep 25, 2018

I'll let @modeswitch review this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment