Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 456 #504

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
3 participants
@DinahLin
Copy link
Contributor

commented Sep 24, 2018

If it is the success, the filename is undefined, when we write a file from original to a destination.
I change code at fs.write.spec.js

DinahLin added some commits Sep 24, 2018

@@ -5,6 +5,18 @@ var expect = require('chai').expect;
describe('fs.write', function() {
beforeEach(util.setup);
afterEach(util.cleanup);

// the file is underfined, will create problem

This comment has been minimized.

Copy link
@AHKol

AHKol Sep 24, 2018

Contributor

Typo nit: 'underfined' might be intended to spell 'undefined'.

This comment has been minimized.

Copy link
@DinahLin

DinahLin Sep 26, 2018

Author Contributor

Thank you for telling me, I will fix the problem late.

@humphd
Copy link
Contributor

left a comment

One small fix, and I think this is good to merge. Please make this change, and push another commit.


// if the file is undefined, it will create problems
//
it('should be a error',function(done){

This comment has been minimized.

Copy link
@humphd

humphd Oct 9, 2018

Contributor

Please move your comment above into the test message like this:

it('should error if the file name is undefined', function(done) {

humphd added a commit that referenced this pull request Dec 15, 2018

@humphd

This comment has been minimized.

Copy link
Contributor

commented Dec 15, 2018

I've fixed this up, rebased, and landed in 4a5d8c1 with some extra fixes in 158f624.

@humphd humphd closed this Dec 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.