Join GitHub today
Fix #500: add test for fs.open to check flags #507
👏🏽 This 👏🏽 is 👏🏽 some 👏🏽 good 👏🏽 stuff 👏🏽 @Mera-Gangapersaud!
It looks like we have one nit (nit-pick, ie. something small) to fix up according to TravisCI:
When you have a chance, feel free to fix the linting issue. Then you can either add a new commit with a message of something like
To do the second method (which will keep a cleaner commit history and I know you're a perfectionist), you'll need to:
(1) Correct the linting issue in your editor of choice
Give me a shout if you need any help with this!
I see the linting issue is fixed - nice work!!
We now have a new problem (that isn't soo bad..). Since we amended that linting fix to the previous commit, you did a good thing and updated the commit message. However, this over wrote the old commit message, which was more descriptive and what we were looking for.
Can you run