Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #661: replaced var with const #669

Merged
merged 2 commits into from Jan 31, 2019

Conversation

Projects
None yet
5 participants
@andrewkoung
Copy link
Contributor

andrewkoung commented Jan 24, 2019

Changed the every keyword "var" in the whole file to use const.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #669 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #669   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...f835d73. Read the comment docs.

@humphd
Copy link
Contributor

humphd left a comment

This is looking really good. I see one more that needs to get fixed on line 93.

Also, can you add 'use strict'; to the top?

Update fs.symlink.spec.js
fixed line 93 and added strict mode
@andrewkoung

This comment has been minimized.

Copy link
Contributor Author

andrewkoung commented Jan 25, 2019

@humphd changes made

@jadach1
Copy link
Contributor

jadach1 left a comment

Nice work. Everything looks to be in order.

@jatinkumarg
Copy link
Contributor

jatinkumarg left a comment

Great, I have also added 'use strict' at the top of the fs.readdir.spec.js file.

@jadach1
Copy link
Contributor

jadach1 left a comment

Looks good !

@humphd

humphd approved these changes Jan 31, 2019

Copy link
Contributor

humphd left a comment

Looks great now.

@humphd humphd merged commit 4de0bbf into filerjs:master Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.