Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed fs.watch.spec.js according to filed issue-666 #680

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
3 participants
@vrozin
Copy link
Contributor

vrozin commented Jan 27, 2019

The file had its variable being declared with usage of "var" -> changed to "let" and "const" where applicable; added "use strict" at global scope.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 27, 2019

Codecov Report

Merging #680 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #680   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...60478fc. Read the comment docs.

@@ -126,4 +128,4 @@ describe('fs.watch', function() {
});
});
});
});
});

This comment has been minimized.

@humphd

humphd Jan 31, 2019

Contributor

One tip: it's always a good idea to end files with a newline. We do this for cases where files get processed/concatenated together, and you want to avoid the case that the last line of one file, and the first line of the next, get joined and cause an error.

@humphd

humphd approved these changes Jan 31, 2019

Copy link
Contributor

humphd left a comment

Looks good, one comment for next time.

@humphd humphd merged commit 5918cf6 into filerjs:master Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.