Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue-670: Changed var to const #687

Merged
merged 4 commits into from Feb 5, 2019

Conversation

Projects
None yet
5 participants
@AlvinValdez
Copy link
Contributor

AlvinValdez commented Jan 28, 2019

Updated code in filer/src/stats.js to use const instead of var.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #687 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #687   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232
Impacted Files Coverage Δ
src/stats.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...22e9e9f. Read the comment docs.

@yuansheng1989

This comment has been minimized.

Copy link
Contributor

yuansheng1989 commented Jan 29, 2019

You can add 'use strict' in the top of the file

@AlvinValdez AlvinValdez changed the title Changed var to const Fix for issue-670: Changed var to const Jan 30, 2019

@SahibArora
Copy link
Contributor

SahibArora left a comment

Try using the steps provided > https://github.com/filerjs/filer/blob/develop/CONTRIBUTING.md#how-to-contribute
Must remove your error if you only changed the var to const/let in previous commits :)

AlvinValdez added some commits Jan 31, 2019

@humphd

humphd approved these changes Feb 5, 2019

Copy link
Contributor

humphd left a comment

Looks good.

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Feb 5, 2019

One tip: instead of Fix for issue-670 use Fixes #670 and GitHub will autoclose the issue when this gets merged. See https://help.github.com/articles/closing-issues-using-keywords/

@humphd humphd merged commit 0ec51a1 into filerjs:master Feb 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.