Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Issue-689 indexedDB.js #700

Merged
merged 4 commits into from Jan 31, 2019

Conversation

Projects
None yet
3 participants
@vlogozzo
Copy link
Contributor

vlogozzo commented Jan 29, 2019

I've made some changes to the indexedDB.js to use let and const on its local values

@vlogozzo vlogozzo changed the title Issue-689 indexedDB.js fixed Issue-689 indexedDB.js Jan 29, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232
Impacted Files Coverage Δ
src/shell/environment.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...428279d. Read the comment docs.

@humphd
Copy link
Contributor

humphd left a comment

I notice you updated some dependency versions in package.json. That's a good idea, but not in this bug. We tend to try and isolate changes from one another, and use a bug-per-fix. It makes it easier to track changes over time that way, and figure out where something went wrong when things break.

Can you unto these changes?

git checkout master package*

This will overwrite the files with what's on master. You can create a new branch and update these if you want in a new PR:

git checkout -b update-deps master
npm update
@vlogozzo

This comment has been minimized.

Copy link
Contributor Author

vlogozzo commented Jan 31, 2019

@humphd

humphd approved these changes Jan 31, 2019

Copy link
Contributor

humphd left a comment

Thanks, this is better!

@humphd humphd merged commit 43bba42 into filerjs:master Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vlogozzo vlogozzo deleted the vlogozzo:issue689 branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.