Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated environment.js to use const insted of var for constant property #709

Merged
merged 2 commits into from Jan 31, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+2 −1
Diff settings

Always

Just for now

Copy path View file
@@ -1,4 +1,5 @@
var defaults = require('../constants.js').ENVIRONMENT;
'use strict';
const defaults = require('../constants.js').ENVIRONMENT;

This comment has been minimized.

@vrozin

vrozin Jan 30, 2019

Contributor

Hey, I think you should also include 'use strict'; to the head of the file.

This comment has been minimized.

@pbrahmbhatt3

pbrahmbhatt3 Jan 31, 2019

Author Contributor

good catch! Thanks. :) @vrozin


module.exports = function Environment(env) {
env = env || {};
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.