Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-686 - rfs.mkdtemp.spec.js #717

Merged
merged 3 commits into from Feb 5, 2019

Conversation

Projects
None yet
4 participants
@cmchumak
Copy link
Contributor

cmchumak commented Jan 30, 2019

No description provided.

@cmchumak cmchumak closed this Jan 30, 2019

@cmchumak cmchumak reopened this Jan 30, 2019

@cmchumak cmchumak changed the title Replaced 'var' with 'const' where applicable Issue-686 - rfs.mkdtemp.spec.js Jan 30, 2019

@@ -1,6 +1,8 @@
const util = require('../lib/test-utils.js');
const expect = require('chai').expect;

'use strict';

This comment has been minimized.

@bonbon12

bonbon12 Jan 30, 2019

Contributor

'use strict' should be at the top of the code to ensure all the code below is ran in strict mode

This comment has been minimized.

@cmchumak

cmchumak Jan 30, 2019

Author Contributor

Done. Thanks.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #717 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #717   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...176b488. Read the comment docs.

@cmchumak cmchumak closed this Jan 30, 2019

@cmchumak cmchumak reopened this Jan 30, 2019

@humphd

humphd approved these changes Feb 5, 2019

Copy link
Contributor

humphd left a comment

This looks great. One tip: when you file your PR, instead of saying Issue-686, use Fixes #686 and GitHub will auto-close the issue for you.

@humphd humphd merged commit 3c51bbb into filerjs:master Feb 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.