Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix var to const #723

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@QingLianLiu
Copy link

QingLianLiu commented Jan 30, 2019

Fix var into const

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #723 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #723   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...abb5143. Read the comment docs.

@jatinkumarg
Copy link
Contributor

jatinkumarg left a comment

Great work, you can also add 'use strict' at the top of the page.

@PriyankaCodes99

This comment has been minimized.

Copy link
Contributor

PriyankaCodes99 commented Jan 31, 2019

Looks good. As stated, 'use strict' can be added for strict mode.

@humphd
Copy link
Contributor

humphd left a comment

This looks really good. I also agree with both your reviewers that you need to add 'use strict; to the top of the file. Please do that, then git add, git commit, and git push again to this same branch. It will get added. Let me know when that's done and I'll re-review.

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Feb 12, 2019

@QingLianLiu how is this coming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.