Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fs.mkdir.spec.js #725

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@jfeng43
Copy link

jfeng43 commented Jan 30, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #725 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #725   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...85a7193. Read the comment docs.

@SahibArora

This comment has been minimized.

Copy link
Contributor

SahibArora commented Jan 30, 2019

Nice work, It will make it more amazing if you could give some details of whats done, will make it easy for people to follow.
As you know, we developers are lazy ;)

@ApolllonDev

This comment has been minimized.

Copy link
Contributor

ApolllonDev commented Feb 1, 2019

@humphd

humphd approved these changes Feb 5, 2019

Copy link
Contributor

humphd left a comment

@jfeng43 this PR looks great. Your changes are correct, and you've done a good job with the code. As mentioned by your reviewers, make sure that you include a description of all changes when you submit a PR, and not just a title.

Also, since this is a duplicate fix, I'm going to close it (I've already merged these changes from another student). However, I'll accept your work here as "complete." In the future, we should do more work to make sure that multiple people aren't working on the same fixes. However, it happens, and it's not the end of the world.

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Feb 5, 2019

Closing since this is duplicating changes we already have from another PR.

@humphd humphd closed this Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.