Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update fs.mkdir.spec.js #725
@@ Coverage Diff @@ ## master #725 +/- ## ======================================= Coverage 86.71% 86.71% ======================================= Files 16 16 Lines 1746 1746 ======================================= Hits 1514 1514 Misses 232 232
humphd left a comment
@jfeng43 this PR looks great. Your changes are correct, and you've done a good job with the code. As mentioned by your reviewers, make sure that you include a description of all changes when you submit a PR, and not just a title.
Also, since this is a duplicate fix, I'm going to close it (I've already merged these changes from another student). However, I'll accept your work here as "complete." In the future, we should do more work to make sure that multiple people aren't working on the same fixes. However, it happens, and it's not the end of the world.