Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #715 Update fs.lstat.spec.js to have proper const and let instead of var and added 'use strict' #727

Merged
merged 7 commits into from Feb 12, 2019

Conversation

Projects
None yet
4 participants
@hoaianhkhang
Copy link
Contributor

hoaianhkhang commented Jan 30, 2019

I edit the code to change some let into const and tested it again

hoaianhkhang added some commits Jan 30, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #727 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
- Coverage   86.71%   86.63%   -0.08%     
==========================================
  Files          16       16              
  Lines        1746     1736      -10     
==========================================
- Hits         1514     1504      -10     
  Misses        232      232
Impacted Files Coverage Δ
src/filesystem/interface.js 93.29% <0%> (-0.39%) ⬇️
src/stats.js 100% <0%> (ø) ⬆️
src/fs-watcher.js 92.3% <0%> (ø) ⬆️
src/shell/environment.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...fbdd179. Read the comment docs.

@pbrahmbhatt3

This comment has been minimized.

Copy link
Contributor

pbrahmbhatt3 commented Jan 31, 2019

Hi @hoaianhkhang, good work! I think you can make your pull request better by giving some desciption of the changes you have made. if you click on the 3 horizontal dots you will be given an option to edit your description and you can describe your changes.
untitled

@humphd
Copy link
Contributor

humphd left a comment

This looks good.

You can actually change all the let fs = util.fs(); and let fsPromises = util.fs().promises; to use const vs. let, since the variable will never change after being declared. Please do those changes and let me know when it's updated, so I can re-review.

hoaianhkhang added some commits Feb 5, 2019

@hoaianhkhang

This comment has been minimized.

Copy link
Contributor Author

hoaianhkhang commented Feb 5, 2019

I have changed the file, can you check it again please?

@humphd
Copy link
Contributor

humphd left a comment

Can you revert the blank line changes you made?

@@ -13,7 +13,6 @@ describe('fs.lstat', function() {

it('should return an error if path does not exist', function(done) {
const fs = util.fs();

This comment has been minimized.

@humphd

humphd Feb 5, 2019

Contributor

Why remove all these blank lines? It's normally a bad idea to touch lines that aren't really part of this fix. The reason it's generally avoided is that it will alter the history of these lines in git, making them look like they were changed in this PR, but really they weren't.

This comment has been minimized.

@hoaianhkhang

hoaianhkhang Feb 6, 2019

Author Contributor

I have changed the file again with the space

@humphd

humphd approved these changes Feb 12, 2019

@humphd humphd merged commit e6f8ef2 into filerjs:master Feb 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.