Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated file for issue #714 #732

merged 2 commits into from Feb 8, 2019


None yet
3 participants
Copy link

otkach commented Jan 31, 2019

All vars were changed to let or const. Also 'use strict'; was added to file.


This comment has been minimized.

Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #732 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
- Coverage   86.71%   86.63%   -0.08%     
  Files          16       16              
  Lines        1746     1736      -10     
- Hits         1514     1504      -10     
  Misses        232      232
Impacted Files Coverage Δ
src/filesystem/interface.js 93.29% <0%> (-0.39%) ⬇️
src/stats.js 100% <0%> (ø) ⬆️
src/fs-watcher.js 92.3% <0%> (ø) ⬆️
src/shell/environment.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...6fbc69a. Read the comment docs.

Copy link

humphd left a comment

You can actually change all the uses of let to const below, since the variables don't every change after being declared.

Also, move line 3 to line 1 (make it first).

Let me know when you've updated this and I'll re-review.


This comment has been minimized.

Copy link
Contributor Author

otkach commented Feb 6, 2019

@humphd all changes was made due to your request. Please check if everything is fine.


humphd approved these changes Feb 8, 2019

@humphd humphd merged commit 3447ec9 into filerjs:master Feb 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.