Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the declaration types [issue-734] #735

Merged
merged 3 commits into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@aqeelparpia
Copy link

aqeelparpia commented Feb 1, 2019

Fixed!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #735 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #735   +/-   ##
======================================
  Coverage    86.6%   86.6%           
======================================
  Files          16      16           
  Lines        1739    1739           
======================================
  Hits         1506    1506           
  Misses        233     233

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3e567...c515865. Read the comment docs.

@humphd
Copy link
Contributor

humphd left a comment

This is looking really good. A couple of small things to fix, and then I can re-review it.

Show resolved Hide resolved tests/spec/fs.xattr.spec.js
Show resolved Hide resolved tests/spec/fs.xattr.spec.js Outdated
Aqeel Parpia Aqeel Parpia

@aqeelparpia aqeelparpia force-pushed the aqeelparpia:issue-734 branch from 33e477e to 3471848 Feb 8, 2019

Aqeel Parpia added some commits Feb 8, 2019

Aqeel Parpia Aqeel Parpia
Aqeel Parpia Aqeel Parpia
@humphd

humphd approved these changes Feb 8, 2019

@humphd humphd merged commit c515865 into filerjs:master Feb 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.