Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase test timeout to 10 seconds from 5 seconds #742

Merged
merged 1 commit into from Feb 23, 2019

Conversation

@ApolllonDev
Copy link
Contributor

commented Feb 22, 2019

Increased test timeout to 10 seconds from 5 seconds due to exceeded timeouts on the Firefox tests as suggested by @humphd.

fs.watch
× "before each" hook: p for "should get a change event when writing a file beneath root dir with recursive=true"
  Firefox 65.0.0 (Windows 10.0.0)
Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

× "after each" hook: h for "should get a change event when writing a file beneath root dir with recursive=true"
  Firefox 65.0.0 (Windows 10.0.0)
Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
@codecov-io

This comment has been minimized.

Copy link

commented Feb 22, 2019

Codecov Report

Merging #742 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #742   +/-   ##
======================================
  Coverage    86.6%   86.6%           
======================================
  Files          16      16           
  Lines        1739    1739           
======================================
  Hits         1506    1506           
  Misses        233     233

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d10d64...078fc5d. Read the comment docs.

@humphd
humphd approved these changes Feb 23, 2019
Copy link
Contributor

left a comment

This is great, thanks for doing it, as I've heard from other students with slower laptops hitting this issue too.

@humphd humphd merged commit 9d3f220 into filerjs:master Feb 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.