Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #625 Add test for fs.readlink() when the path isn't a symbolic link #744
@@ Coverage Diff @@ ## master #744 +/- ## ========================================== + Coverage 86.6% 86.65% +0.05% ========================================== Files 16 16 Lines 1739 1739 ========================================== + Hits 1506 1507 +1 + Misses 233 232 -1
humphd left a comment
This does exactly what we needed, and I can see the coverage info has gone up. Nice work.
One thing to be aware of: if you look at the changes this PR makes, it's touching a lot of lines that aren't related to the code you're adding. It looks like your editor has automatically added extra whitespace in lots of places. This is something you'll want to avoid when submitting PRs to projects, since altering these lines will create what is known as "spurious whitespace changes." In other words, it looks like these lines were altered as part of this commit, but in reality, only the whitespace was changed. Doing this makes it harder to track the history of code back in time.
I'll allow it here, since it's not a huge deal in this case. But be aware for the future, and alter your editor to not do this, or you'll have your PRs rejected.