Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Support #13

Closed
TomasKostadinov opened this issue Jul 28, 2018 · 6 comments
Closed

SSL Support #13

TomasKostadinov opened this issue Jul 28, 2018 · 6 comments

Comments

@TomasKostadinov
Copy link

@TomasKostadinov TomasKostadinov commented Jul 28, 2018

Is there currently an easy way to use the docker image with ssl (e.g. issued by let's encrypt)?
If so, how do I install certificates?

Thanks in advance, loving filerun so far!

@filerun

This comment has been minimized.

Copy link
Owner

@filerun filerun commented Sep 6, 2018

The only way would be to install a reverse proxy in front of it (https://www.digitalocean.com/community/tutorials/how-to-secure-haproxy-with-let-s-encrypt-on-ubuntu-14-04#step-3-%E2%80%94-installing-haproxy)
I am looking into finding an easier solution.

@pirate

This comment has been minimized.

Copy link

@pirate pirate commented Sep 23, 2018

I just set up a reverse proxy with nginx, but the issue is that filerun still has http hardcoded in many of the urls it requests (which a reverse proxy cant fix easily).

It may be worth adding a docker environment variable like HTTP_PROTOCOL=https or BASE_URL=https://drive.example.com which gets passed down to fix the broken urls.

@filerun

This comment has been minimized.

Copy link
Owner

@filerun filerun commented Sep 23, 2018

FileRun does not use urls with hardcoded protocol. Make sure you are using the latest version.

@filerun

This comment has been minimized.

Copy link
Owner

@filerun filerun commented Sep 23, 2018

If using the latest version and still having this problem, make sure your reverse proxy passes HTTP_X_FORWARDED_PROTO, or HTTP_X_FORWARDED_SSL, or HTTP_X_FORWARDED_PORT. FileRun looks for any of these to determine if the URLs should start using HTTP or HTTPS.

@filerun filerun closed this Feb 13, 2019
@scambier

This comment has been minimized.

Copy link

@scambier scambier commented Aug 8, 2019

If you're on this thread after a Google search, just add this line in your nginx conf file, in the location block: proxy_set_header X-Forwarded-Proto https;

@Guisardo

This comment has been minimized.

Copy link

@Guisardo Guisardo commented Sep 24, 2019

Thanks @scambier ! It works perfectly.
@filerun , can you add all this to the Readme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.