From d81ce8c6bc67f3edea2c72248a417a66ae366659 Mon Sep 17 00:00:00 2001 From: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Thu, 15 Jun 2023 00:04:42 +0900 Subject: [PATCH] Fix incorrect tooltip --- .../Views/LayoutModes/DetailsLayoutBrowser.xaml | 7 +++++++ .../Views/LayoutModes/DetailsLayoutBrowser.xaml.cs | 13 ++++++++++++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml b/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml index 59e334d683d4..a421809377e3 100644 --- a/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml +++ b/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml @@ -955,6 +955,7 @@ x:Name="ItemName" Padding="6,0,0,0" VerticalAlignment="Center" + DataContextChanged="TextBlock_DataContextChanged" IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged" Opacity="{x:Bind Opacity, Mode=OneWay}" Text="{x:Bind Name, Mode=OneWay}" @@ -1104,6 +1105,7 @@ HorizontalAlignment="Stretch" VerticalAlignment="Center" x:Load="{x:Bind IsRecycleBinItem}" + DataContextChanged="TextBlock_DataContextChanged" IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged" Style="{StaticResource ColumnContentTextBlock}" Text="{x:Bind AsRecycleBinItem.ItemOriginalPath, Mode=OneWay}" @@ -1117,6 +1119,7 @@ HorizontalAlignment="Stretch" VerticalAlignment="Center" x:Load="{x:Bind IsRecycleBinItem}" + DataContextChanged="TextBlock_DataContextChanged" IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged" Style="{StaticResource ColumnContentTextBlock}" Text="{x:Bind AsRecycleBinItem.ItemDateDeleted, Mode=OneWay}" @@ -1129,6 +1132,7 @@ Padding="10,0,0,0" HorizontalAlignment="Stretch" VerticalAlignment="Center" + DataContextChanged="TextBlock_DataContextChanged" IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged" Style="{StaticResource ColumnContentTextBlock}" Text="{x:Bind ItemDateModified, Mode=OneWay}" @@ -1141,6 +1145,7 @@ Padding="10,0,0,0" HorizontalAlignment="Stretch" VerticalAlignment="Center" + DataContextChanged="TextBlock_DataContextChanged" IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged" Style="{StaticResource ColumnContentTextBlock}" Text="{x:Bind ItemDateCreated, Mode=OneWay}" @@ -1153,6 +1158,7 @@ Padding="10,0,0,0" HorizontalAlignment="Stretch" VerticalAlignment="Center" + DataContextChanged="TextBlock_DataContextChanged" IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged" Style="{StaticResource ColumnContentTextBlock}" Text="{x:Bind ItemType, Mode=OneWay}" @@ -1165,6 +1171,7 @@ Padding="10,0,0,0" HorizontalAlignment="Stretch" VerticalAlignment="Center" + DataContextChanged="TextBlock_DataContextChanged" IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged" Style="{StaticResource ColumnContentTextBlock}" Text="{x:Bind FileSize, Mode=OneWay}" diff --git a/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs b/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs index d80803bf3023..e7cebda90fbf 100644 --- a/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs +++ b/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs @@ -855,7 +855,18 @@ private void UpdateCheckboxVisibility(object sender, bool isPointerOver) // Workaround for https://github.com/microsoft/microsoft-ui-xaml/issues/170 private void TextBlock_IsTextTrimmedChanged(TextBlock sender, IsTextTrimmedChangedEventArgs e) { - ToolTipService.SetToolTip(sender, sender.IsTextTrimmed ? sender.Text : null); + SetToolTip(sender); + } + + private void TextBlock_DataContextChanged(FrameworkElement sender, DataContextChangedEventArgs e) + { + if (sender is TextBlock textBlock) + SetToolTip(textBlock); + } + + private void SetToolTip(TextBlock textBlock) + { + ToolTipService.SetToolTip(textBlock, textBlock.IsTextTrimmed ? textBlock.Text : null); } } }