Skip to content

Open taskbar-pinned folders in existing instance #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 15, 2020

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jul 15, 2020

Fixes #1448

With this change folders pinned on the taskbar will be opened in the last used Files instance (in a new tab).
Folders launched from the command line will always open in a new instance.
Clicking the Files tile or start menu icon will always open a new instance.

TODO:

  • add a setting to activate the new behaviour
  • [maybe] if the selected tab in the target instance is "new tab" page, open folder in that tab

2020-07-15-08-14-34-2-Trim2

@gave92 gave92 marked this pull request as draft July 15, 2020 06:24
@ghost ghost added the needs - code review label Jul 15, 2020
Copy link
Contributor

@jaigak jaigak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new behavior should be the default the existing behavior should be optional.

@yaira2 yaira2 self-requested a review July 15, 2020 11:53
@soumyamahunt
Copy link
Contributor

How does this work if app is minimized??

@jaigak
Copy link
Contributor

jaigak commented Jul 15, 2020

How does this work if app is minimized??

The app will be activated by Windows.

@gave92 gave92 marked this pull request as ready for review July 15, 2020 19:00
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 15, 2020
@yaira2 yaira2 merged commit 0a3e614 into files-community:master Jul 15, 2020
@gave92 gave92 deleted the appstart branch July 15, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open pinned folders in existing windows of F-UWP instead of creating a new one
4 participants