Skip to content

Implemented folder dropdown list for Navigationbar #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 23, 2020

Conversation

soumyamahunt
Copy link
Contributor

@soumyamahunt soumyamahunt commented Jul 22, 2020

As requested by @mdtauk, implemented clicking on any path items chevron to get a drop-down list of all folders in that directory:

ewvPDaCFgF

@soumyamahunt
Copy link
Contributor Author

Only thing remaining is Windows Explorer style split-revael-brush.

explorer_qSKvl9ohUL (2)

I am currently working on it but so far what I have come up with aren't visually appealing.

@soumyamahunt
Copy link
Contributor Author

The best I could come up with:

ApplicationFrameHost_gaLOkWFBPr (2)

@jaigak
Copy link
Contributor

jaigak commented Jul 22, 2020

@soumyamahunt Which issue was this feature proposed?

@soumyamahunt
Copy link
Contributor Author

@soumyamahunt Which issue was this feature proposed?

Not in any issue, a user asked me about implementing this feature, which is available in Windows Explorer.

@yaira2 yaira2 self-requested a review July 22, 2020 14:47
@jaigak
Copy link
Contributor

jaigak commented Jul 22, 2020

@soumyamahunt Whenever you are opening a PR in the repository make sure that there's an issue associated with it. If there is no issue, create one before starting a PR.

@lukeblevins
Copy link
Contributor

@soumyamahunt Great work!

Maybe we can add a MaxHeight to the drop downs?

@lukeblevins lukeblevins self-requested a review July 22, 2020 19:57
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes work great, and we'll look forward to merging this one soon.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 23, 2020
@yaira2 yaira2 merged commit e84b383 into files-community:master Jul 23, 2020
@soumyamahunt soumyamahunt deleted the pathbox-dropdown branch July 23, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants