Fix: Fixed an issue where panes couldn't be switched via touch #15493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
previously approved these changes
May 29, 2024
Member
yaira2
left a comment
yaira2
left a comment
There was a problem hiding this comment.
This looks good to me but I'd like to wait until @hishitetsu can review.
yaira2
added
the
ready to merge
yaira2
changed the title
hishitetsu
approved these changes
May 31, 2024
Member
hishitetsu
left a comment
hishitetsu
left a comment
There was a problem hiding this comment.
This also slightly changes the behavior when using a mouse. The pane will switch when the button is pressed instead of when the button is released, but it would rather do so.
LGTM
Contributor
Author
|
@hishitetsu If we want to specify more precisely the finger tap, I can use |
Member
I'd rather use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.https://discord.com/channels/725513575971684472/958783217941487616/1245094972043296848
Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.