Code Quality: Convert Multiple Localized Strings to ICU Message Format | Add custom number format #15517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
BEFORE
AFTER
|
Member
|
@XTorLukas which localization is that? |
Contributor
Author
This #15514 (comment) |
Co-authored-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
Co-authored-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
yaira2
approved these changes
May 30, 2024
yaira2
added
ready to merge
0x5bfa
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.
From #15503
TODO list: #15503 (comment)
Add custom number format
Add better number format from default
1,000,000.000to1 000 000.000via custom format for used this{0, number}