Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 12, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app
  2. Go to a folder that contains desktop.ini
  3. This is not reproducible always

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 12, 2024
@yaira2 yaira2 changed the title Fix: Fixed an issue where the execution order of post-enumeration might be different in ShellViewModel Code Quality: Fixed an issue where the execution order of post-enumeration might be different in ShellViewModel Jul 12, 2024
@yaira2 yaira2 merged commit a3d73dd into files-community:main Jul 12, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Fix-ArgumentNullException branch July 12, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Crash when clicking on the Explorer icon

2 participants