From 28444d92a33e9bcacca9c1ce4f8cb60e811656dd Mon Sep 17 00:00:00 2001 From: Martin Anderson Date: Wed, 24 Jul 2024 16:41:50 +0100 Subject: [PATCH 1/4] Added Eject 12, and Pinned 12 Icons Also added explicit layer sizes on non 16px icons --- .../ThemedIcon/Styles/Icons.Action.xaml | 54 +++++++++++ .../ThemedIcon/Styles/Icons.SizeLayout28.xaml | 92 +++++++++++++++---- .../ThemedIcon/Styles/Icons.Status.xaml | 20 +++- .../UserControls/ThemedIconsUC.xaml | 2 +- 4 files changed, 145 insertions(+), 23 deletions(-) diff --git a/src/Files.App.Controls/ThemedIcon/Styles/Icons.Action.xaml b/src/Files.App.Controls/ThemedIcon/Styles/Icons.Action.xaml index eb99ac4f0b96..aa8ef8ff4496 100644 --- a/src/Files.App.Controls/ThemedIcon/Styles/Icons.Action.xaml +++ b/src/Files.App.Controls/ThemedIcon/Styles/Icons.Action.xaml @@ -220,4 +220,58 @@ + + + + diff --git a/src/Files.App.Controls/ThemedIcon/Styles/Icons.SizeLayout28.xaml b/src/Files.App.Controls/ThemedIcon/Styles/Icons.SizeLayout28.xaml index 5ad48867f5b9..acef0be97f77 100644 --- a/src/Files.App.Controls/ThemedIcon/Styles/Icons.SizeLayout28.xaml +++ b/src/Files.App.Controls/ThemedIcon/Styles/Icons.SizeLayout28.xaml @@ -18,8 +18,14 @@ - - + + @@ -40,8 +46,14 @@ - - + + @@ -62,7 +74,10 @@ - + @@ -83,8 +98,14 @@ - - + + @@ -105,8 +126,14 @@ - - + + @@ -127,8 +154,14 @@ - - + + @@ -148,8 +181,14 @@ - - + + @@ -174,7 +213,10 @@ LayerType="Base" Opacity="0.3" PathData="m14.71,10.71l3.51,3.51c.47.47.14,1.28-.53,1.28h-7.38c-.67,0-1-.81-.53-1.28l3.51-3.51c.39-.39,1.02-.39,1.41,0Z" /> - + @@ -194,12 +236,19 @@ - + - + @@ -220,12 +269,19 @@ - + - + diff --git a/src/Files.App.Controls/ThemedIcon/Styles/Icons.Status.xaml b/src/Files.App.Controls/ThemedIcon/Styles/Icons.Status.xaml index ba4164f2f70c..330a4630624c 100644 --- a/src/Files.App.Controls/ThemedIcon/Styles/Icons.Status.xaml +++ b/src/Files.App.Controls/ThemedIcon/Styles/Icons.Status.xaml @@ -326,8 +326,14 @@ - - + + @@ -348,8 +354,14 @@ - - + + diff --git a/tests/Files.App.UITests/UserControls/ThemedIconsUC.xaml b/tests/Files.App.UITests/UserControls/ThemedIconsUC.xaml index ff4be306155c..040363318ba2 100644 --- a/tests/Files.App.UITests/UserControls/ThemedIconsUC.xaml +++ b/tests/Files.App.UITests/UserControls/ThemedIconsUC.xaml @@ -17,7 +17,7 @@ From 68c920aab3e020276ffb09da296965781cc02ffa Mon Sep 17 00:00:00 2001 From: Yair <39923744+yaira2@users.noreply.github.com> Date: Wed, 24 Jul 2024 17:00:38 -0400 Subject: [PATCH 4/4] Update DriveItem.cs --- src/Files.App/Data/Items/DriveItem.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Files.App/Data/Items/DriveItem.cs b/src/Files.App/Data/Items/DriveItem.cs index 1a0d4021c569..118ca94160bd 100644 --- a/src/Files.App/Data/Items/DriveItem.cs +++ b/src/Files.App/Data/Items/DriveItem.cs @@ -195,7 +195,7 @@ public FrameworkElement? ItemDecorator get { if (!IsRemovable) - return null; // Removable items don't need the eject button + return null; // Non-removable items don't need the eject button var itemDecorator = new Button() { @@ -203,8 +203,8 @@ public FrameworkElement? ItemDecorator Content = new ThemedIcon() { Style = Application.Current.Resources["App.ThemedIcons.Actions.Eject.12"] as Style, - Height = 16, - Width = 16 + Height = 12, + Width = 12 } };