Skip to content

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Jul 25, 2024

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed the section state is preserved across sessions

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Jul 25, 2024
@yaira2 yaira2 requested a review from 0x5bfa July 25, 2024 20:26
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise LGTM

@yaira2 yaira2 force-pushed the ya/SettingsViewModel branch 3 times, most recently from d6bbf57 to 4764d64 Compare July 28, 2024 19:52
@yaira2 yaira2 force-pushed the ya/SettingsViewModel branch from 4d435e5 to 5a069cb Compare July 28, 2024 20:14
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jul 28, 2024
@yaira2 yaira2 merged commit 7313452 into main Jul 29, 2024
@yaira2 yaira2 deleted the ya/SettingsViewModel branch July 29, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants