Skip to content

Conversation

@hishitetsu
Copy link
Member

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Add duplicate keys in desktop.ini.
  2. Open the folder which contains that desktop.ini.
  3. See the custom background feature works.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Fixed System.ArgumentException in WindowsIniService.GetData Code Quality: Fixed System.ArgumentException in WindowsIniService.GetData Jul 28, 2024
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 28, 2024
@yaira2 yaira2 merged commit ed41158 into files-community:main Jul 28, 2024
@hishitetsu hishitetsu deleted the FixDuplicateKeysInIni branch July 30, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: System.ArgumentException: An item with the same key has already been added. Key: Mode

2 participants