Skip to content

Fix: Fixed drag & drop support for script shortcuts #17827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
Merged

Fix: Fixed drag & drop support for script shortcuts #17827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1cf22b
fix: Allow drag-and-drop onto script shortcuts
learncold Nov 6, 2025
12075d0
Apply suggestion from @yaira2
yaira2 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Files.App/Data/Items/ListedItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,7 @@ public override string Name
public SHOW_WINDOW_CMD ShowWindowCommand { get; set; }
public bool IsUrl { get; set; }
public bool IsSymLink { get; set; }
public override bool IsScriptFile => FileExtensionHelpers.IsScriptFile(TargetPath);
public override bool IsExecutable => FileExtensionHelpers.IsExecutableFile(TargetPath, true);
}

Expand Down Expand Up @@ -786,6 +787,7 @@ public override string Name
public SHOW_WINDOW_CMD ShowWindowCommand { get; set; }
public bool IsUrl { get; set; }
public bool IsSymLink { get; set; }
public override bool IsScriptFile => FileExtensionHelpers.IsScriptFile(TargetPath);
public override bool IsExecutable => FileExtensionHelpers.IsExecutableFile(TargetPath, true);
}
public interface IGitItem : IListedItem
Expand Down
2 changes: 1 addition & 1 deletion src/Files.Shared/Helpers/FileExtensionHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ public static bool IsCertificateFile(string? filePathToCheck)
/// <returns><c>true</c> if the filePathToCheck is a script file; otherwise, <c>false</c>.</returns>
public static bool IsScriptFile(string? filePathToCheck)
{
return HasExtension(filePathToCheck, ".py", ".ahk");
return HasExtension(filePathToCheck, ".py", ".ahk", ".bat", ".cmd", ".ps1");
}

/// <summary>
Expand Down
Loading