Add support for Recycle Bin #840

gave92 · 2020-05-25T21:28:59Z

Hello this pull request adds support for browsing the Recycle Bin!
"Support" here means that the recycle bin can be browsed just like any other folder in Files UWP, it's not just a "link" that opens the recycle bin in explorer.

How it works

As I'm not aware of any way to properly access the recycle bin folder from the UWP app, I'm making use of Files UWP full trust process. The fulltrust process enumerates the contents of the recycle bin using the Shell32 api and send the results to the UWP app. Communication between the fulltrust process and the UWP app is done through AppService.

NB: This requires to change the fulltrust process lifecyle: instead of starting a new instance every time to handle the commands to open CMD, toggle QuickLook, etc., a single instance keeps running until the UWP app is closed or suspended.

What works

New entry on the sidebar with localized name of the recycle bin
Enumerating recycle bin elements
Monitor filesystem changes and refresh items
Showing the thumbnails for deleted files
Properties dialog for deleted files
Deleting files from the recycle bin

What's missing

A button to empty recycle bin
A customized context menu with the proper options (e.g "restore")

Let me know what you think of this, if you approve of the "architectural" changes I can keep working to complete what's missing.

yaira2 · 2020-05-26T01:38:00Z

Support for recycle bin would be great, I am not sure if we want to keep it pinned by default. Can you add a feature flag that turns on/off this feature?

gave92 · 2020-05-26T07:08:10Z

@yaichenbaum yup I can do that, perhaps also add it to the New Tab page? Anyway is not the UI part that worries me :)

@duke7553 I've tried using the Shell32 api from the UWP side (meaning using the function SHGetFolderLocation and other IShellFolder related methods and for some reason I cannot enumerate the contents of the recycle bin. The same code works when executed in the fulltrust process.
Is this what you were suggesting by "accessing the recycling bin by it's GUID"?

yaira2 · 2020-05-26T12:56:57Z

@gave92 I would add it to the new page, but it should be behind the feature flag as well.

gave92 · 2020-05-26T13:04:41Z

@yaichenbaum I'll do that. I'm gonna wait a bit though, until I get some feedback on proposed method for accessing the recycle bin (fulltrust process + appservice).
Perhaps there's a simpler way of doing that that I'm missing.

tsvietOK · 2020-05-27T14:30:44Z

@gave92
First
Repro steps:

Open recycle bin
Navigate to folder inside it
Press Up button on navigation panel
Permission dialog displayed

Second
I think folders in recycle bin should not have ability to be opened, renamed, pinned to sidebar, shared, opened in new windows/tab.
Buttons like Add new item and Open in Terminal should be disabled

Third
"Recycle Bin" tab text untranslated

Fourth
Button "Copy path" causes app crash(try to copy path several times)

tsvietOK · 2020-05-27T14:49:31Z

And last, i don't think it is a good idea to merge this PR without supporting restore and clear recycle bin functions.

tsvietOK · 2020-05-27T14:50:30Z

Other way, mark this feature as Experimental

yaira2 · 2020-05-27T14:50:59Z

And last, i don't think it is a good idea to merge this PR without supporting restore and clear recycle bin functions.

We can do this behind a feature flag, this way we are not making any commitment to the feature and the capabilities can be changed.

Files/Program.cs

gave92 · 2020-05-27T23:55:32Z

Thanks for the feedbacks.

@tsvietOK

Permission dialog displayed => will be fixed when disallowing navigation inside recycle bin folders (see 2)
I think folders in recycle bin should not have ability to be opened, renamed, pinned to sidebar, shared, opened in new windows/tab => agreed, need to customize the context menu and buttons (e.g add an "Empty recycle bin" button and a "Restore" to context menu)
"Recycle Bin" tab text untranslated => solved
Button "Copy path" causes app crash => I cannot reproduce this, but it will go away when we change the buttons/context menu (see 2)

Files.Launcher/Program.cs

Files/Views/InstanceTabsView.xaml.cs

Common/ShellFileItem.cs

yaira2 · 2020-05-28T13:39:38Z

By default, recycle bin should not be pinned to the sidebar.
The app crashes when navigating to recycle bin.

gave92 · 2020-05-28T13:42:34Z

@yaichenbaum Ok I'll change the default to not pinned.
I'm aware of the crash, I'm waiting for the owner of the Vanara library I'm now referencing to publicly release the bug fixed version (I have it locally but it's not on nuget yet).

yaira2 · 2020-05-28T13:45:19Z

@gave92 Is there a way I can test this out in the meantime?

gave92 · 2020-05-28T14:04:24Z

@yaichenbaum Yes please try again with the latest commit.
Notes:

auto refresh of recycle bin contents is disabled until the release of the updated Vanara library
creating/pasting/... a file in the recycle bin crashes the app, I'm not fixing this as the solution will be to have a different context menu and buttons for the recycle bin

yaira2 · 2020-05-28T14:53:14Z

@gave92 I can now open recycle bin but it appears to be empty.

gave92 · 2020-05-28T15:02:46Z

@yaichenbaum Can you check whether while you are in the recycle bin folder (in Files UWP) there's a process called FilesFullTrust.exe running in Task Manager?

yaira2 · 2020-05-28T15:25:51Z

@gave92 I do not see FilesFullTrust.exe in Task Manager.

gave92 · 2020-05-28T21:24:04Z

Thanks for the feedback, the issue should now be fixed!

lukeblevins

With the guarantee that this feature is behind a flag, and otherwise invisible, I'll approve this now.

Restore AppService after suspending Enumerate recycle bin items Use real (recycle bin) item path Display recyclebin localized name Fix up click button, test FileWatcher and Empty recyclebin Treat zip as files, Add file size in bytes Fix properties page, refresh on filesystem changes, move ShellFileItem to common project Fix create file in recyclebin Fix watchedItemsOperation null in recyclebin, fix EmptyTextState visibility on file delete

Fix crash when opening file in external app Fix OpenShellCommandInExplorer Add flag to pin recyclebin to sidebar Properly watch for recycle bin updates Recycle bin not pinned by default

Fix exception when deleting many files Simplified method to get file size string

lukeblevins · 2020-05-30T18:57:16Z

@gave92 Thanks for clarifying this. As long as the recycle bin location is only visible when a flag inside the Experimental Settings page is toggled from its default state, we can merge this when you've finished work on it.

Delete $I files from recycle bin

gave92 · 2020-05-30T21:11:34Z

A little update on this:

Added customized context menu with "Empty recycle bin" action
Added customized context menu for recycle bin items with "Restore" action
Disabled menu bar "New file" action in recycle bin
Disabled renaming of items in recycle bin
Disabled navigation and opening of items in recycle bin
The option to enable recycle bin support is now in the Experimental settings page

What's missing:

Proper support for cutting from recycle bin: the pasted file will have a funny name like "$RIIJXS0.ext". I'm not sure if we can support this as cutting/pasting uses the Clipboard and I don't know of a way to specify a different destination name when pasting the file
Enable auto refresh when recycle bin contents change: I'm waiting for the release of an updated version of the Vanara library (used to invoke win32 api in a sane manner)

Let me know what you think!

yaira2 · 2020-05-31T02:51:33Z

@duke7553 @gave92 I should have clarified the first time that when I said feature flag, I meant the experimental settings page.

yaira2 · 2020-05-31T03:09:35Z

@gave92 The app doesn't crash but it still won't load any items I have in recycle bin.

gave92 · 2020-05-31T07:06:58Z

Curious. Please check the following:

That there is a "FilesFullTrust.exe" process running after you open the uwp app
That you can open files in normal folders when tapping them in FilesUWP
That no "FilesFullTrust.exe" process is running after you visit the bin from the uwp app

In the application data path ("%localappdata%\packages\FilesUWPDev_xxxxx\LocalState" there should be a "debug_fulltrust.txt" with the logged exception

yaira2 · 2020-05-31T11:40:20Z

@gave92 FilesFullTrust.exe is running, I see the regular debug file but nothing for debug_fulltrust.exe.

gave92 · 2020-05-31T11:56:14Z

Ok so the fulltrust process is not crashing like before which is good... and now I'm confused.

Does opening files from the uwp work? Does the command "Open in terminal" work?
Would you be willing to run the app from this PR in debug mode in visual studio?

yaira2 · 2020-05-31T11:57:43Z

I don't get a crash, it's just that the progress bar keeps loading in recycle bin and doesn't load any items that are there.

yaira2 · 2020-05-31T12:03:27Z

@gave92 It finally loaded after a few minutes, I think we need to figure out a faster way to load recycle bin before shipping it.

gave92 · 2020-05-31T12:06:43Z

Ok just how much stuff is in your recycle bin? xD
I'll test with a lot of files as well. Thanks for finding out the issue.

Edit2: I can confirm this, with a 1000 files it starts to slow down. The solution might be to load incrementally (like a 100 at a time)
Edit3: Could you please check again with the latest commit? Let me know if it's noticeably faster or not (ignore that some info is missing like file size)

yaira2 · 2020-05-31T13:23:51Z

@gave92 It is much faster now.

Common/ShellFileItem.cs

Files/BaseLayout.cs

lukeblevins

Looks great! Maybe in the future we can use this AppService to load the extended properties of all StorageItems from the Shell, rather than using the Windows Runtime APIs.

gave92 marked this pull request as ready for review May 25, 2020 21:31

ghost added the needs - code review label May 25, 2020

This comment has been minimized.

Sign in to view

yaira2 requested review from lukeblevins and tsvietOK May 27, 2020 13:25

ADeltaX reviewed May 27, 2020

View reviewed changes

Files/Program.cs Outdated Show resolved Hide resolved

tsvietOK suggested changes May 28, 2020

View reviewed changes

Files.Launcher/Program.cs Outdated Show resolved Hide resolved

Files/Views/InstanceTabsView.xaml.cs Outdated Show resolved Hide resolved

Common/ShellFileItem.cs Outdated Show resolved Hide resolved

gave92 force-pushed the recyclebin_poc branch from 621af1d to a1651a2 Compare May 28, 2020 14:21

lukeblevins approved these changes May 29, 2020

View reviewed changes

gave92 added 3 commits May 29, 2020 20:10

Fix Recycle Bin name not localized

de2a619

Fix crash when opening file in external app Fix OpenShellCommandInExplorer Add flag to pin recyclebin to sidebar Properly watch for recycle bin updates Recycle bin not pinned by default

Add exception logging to fulltrust process, fix crash on folders

b871a51

Fix exception when deleting many files Simplified method to get file size string

gave92 force-pushed the recyclebin_poc branch from e14f582 to b871a51 Compare May 29, 2020 19:09

gave92 added 3 commits May 30, 2020 22:24

Handle file restore from uwp app

574f70c

Delete $I files from recycle bin

Fix delete confirmation dialog

774a840

Moved recycle bin setting to Experimental page

d557d52

Test for faster recyclebin enumeration

e91ffe6

gave92 added 2 commits May 31, 2020 15:36

Adding back file size, type and creationdate info

1a50c1b

Do not display filesize for folders

9d13292

yaira2 reviewed May 31, 2020

View reviewed changes

Common/ShellFileItem.cs Show resolved Hide resolved

yaira2 reviewed May 31, 2020

View reviewed changes

Files/BaseLayout.cs Show resolved Hide resolved

yaira2 reviewed May 31, 2020

View reviewed changes

Files/BaseLayout.cs Outdated Show resolved Hide resolved

yaira2 approved these changes May 31, 2020

View reviewed changes

Recycle bin gets its own context menu

3be58c4

yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 31, 2020

Fix crash on GridViewBrowser

51b6bf6

lukeblevins self-requested a review May 31, 2020 19:03

lukeblevins approved these changes May 31, 2020

View reviewed changes

yaira2 merged commit 768f6b7 into files-community:master May 31, 2020

gave92 deleted the recyclebin_poc branch May 31, 2020 19:43

FelixZacher mentioned this pull request Jun 10, 2020

Add QuickLook integration #969

Closed

Uh oh!

Add support for Recycle Bin #840

Add support for Recycle Bin #840

Uh oh!

Conversation

gave92 commented May 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How it works

What works

What's missing

Uh oh!

This comment has been minimized.

yaira2 commented May 26, 2020

Uh oh!

gave92 commented May 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yaira2 commented May 26, 2020

Uh oh!

gave92 commented May 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsvietOK commented May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsvietOK commented May 27, 2020

Uh oh!

tsvietOK commented May 27, 2020

Uh oh!

yaira2 commented May 27, 2020

Uh oh!

Uh oh!

gave92 commented May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yaira2 commented May 28, 2020

Uh oh!

gave92 commented May 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yaira2 commented May 28, 2020

Uh oh!

gave92 commented May 28, 2020

Uh oh!

yaira2 commented May 28, 2020

Uh oh!

gave92 commented May 28, 2020

Uh oh!

yaira2 commented May 28, 2020

Uh oh!

gave92 commented May 28, 2020

Uh oh!

lukeblevins left a comment

Choose a reason for hiding this comment

Uh oh!

lukeblevins commented May 30, 2020

Uh oh!

gave92 commented May 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yaira2 commented May 31, 2020

Uh oh!

yaira2 commented May 31, 2020

Uh oh!

gave92 commented May 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yaira2 commented May 31, 2020

Uh oh!

gave92 commented May 31, 2020

Uh oh!

yaira2 commented May 31, 2020

Uh oh!

yaira2 commented May 31, 2020

Uh oh!

gave92 commented May 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gave92 commented May 25, 2020 •

edited

Loading

gave92 commented May 26, 2020 •

edited

Loading

gave92 commented May 26, 2020 •

edited

Loading

tsvietOK commented May 27, 2020 •

edited

Loading

gave92 commented May 27, 2020 •

edited

Loading

gave92 commented May 28, 2020 •

edited

Loading

gave92 commented May 30, 2020 •

edited

Loading

gave92 commented May 31, 2020 •

edited

Loading

gave92 commented May 31, 2020 •

edited

Loading