Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database schema version to be stored in the database. #345

Closed
monkeyiq opened this issue Jun 23, 2018 · 1 comment
Closed

Database schema version to be stored in the database. #345

monkeyiq opened this issue Jun 23, 2018 · 1 comment

Comments

@monkeyiq
Copy link
Contributor

If a new table SchemaVersion or something is used with a single integer being the current database layout then a new release can bump the expected version if there were database changes. Then FileSender can warn the sys admin that the database upgrade script must be run to complete the update instead of relying on people remembering/checking this for each time.

@monkeyiq
Copy link
Contributor Author

monkeyiq commented Apr 2, 2019

To allow major database migrations there is now the https://github.com/filesender/filesender/blob/master/classes/data/Metadata.class.php table. I think it is useful to expect the update script to be run to handle minor updates, if there is nothing to update then it should return fairly quickly. With versioning for minor updates there is always the possibility of forgetting to bump the minor version and admins expecting the system to complain only when the update script must be run. If the expectation is to check the later then smaller changes will automatically be handled.

@monkeyiq monkeyiq closed this as completed Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant