Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt #31

Conversation

Shahid-Roofi-Khan
Copy link
Contributor

PR corresponds to below issue:
#30

It generates _DEBUG macro for LInux Platform so that both Unix and Windows can use same macro: _DEBUG for debug specific code

@filipdutescu filipdutescu self-requested a review October 7, 2021 18:54
@filipdutescu filipdutescu self-assigned this Oct 7, 2021
@filipdutescu filipdutescu added acknowledged The issue is being worked on enhancement New feature or request labels Oct 7, 2021
Copy link
Owner

@filipdutescu filipdutescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and thank's for both the PR and the issue. The change seems simple enough and to provide useful usage to others. However, I would like to ask you to please stick to the templates, for any other issues or request, as it helps me better understand the issue and ensure some common ground between contributors.

@filipdutescu filipdutescu added the implemented Feature was implemented and available label Oct 7, 2021
@filipdutescu filipdutescu merged commit 5029171 into filipdutescu:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged The issue is being worked on enhancement New feature or request implemented Feature was implemented and available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants