Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Change code samples following the Runkit pattern #140

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@lnfnunes
Copy link

lnfnunes commented Mar 10, 2019

Alteração simples nos códigos de exemplo ("Como utilizar") de forma que se a pessoa simplesmente consiga copiar e colar no Runkit e o código funcione!
Pois o padrão do Runkit é seguindo o nome da lib e neste caso fica cepPromise e não apenas cep como mostrado na imagem abaixo:

Runkit

image

Readme

image

  • PS: Alterei o import também nos testes unitários para manter um padrão 😉
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling ad22067 on lnfnunes:npm-runkit into 69aa725 on filipedeschamps:master.

4 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling ad22067 on lnfnunes:npm-runkit into 69aa725 on filipedeschamps:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling ad22067 on lnfnunes:npm-runkit into 69aa725 on filipedeschamps:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling ad22067 on lnfnunes:npm-runkit into 69aa725 on filipedeschamps:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling ad22067 on lnfnunes:npm-runkit into 69aa725 on filipedeschamps:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling af4f973 on lnfnunes:npm-runkit into 69aa725 on filipedeschamps:master.

@lnfnunes lnfnunes force-pushed the lnfnunes:npm-runkit branch from ad22067 to af4f973 Mar 10, 2019

@lnfnunes

This comment has been minimized.

Copy link
Author

lnfnunes commented Mar 10, 2019

Obs: Aparentemente o e2e está quebrando um teste, porém não é devido a esta implementação e a correção estou entendendo que já esta aberta no PR #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.