Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error on wrong input #1

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 4 comments
Closed

No error on wrong input #1

GoogleCodeExporter opened this issue Mar 14, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Mar 14, 2015

> What steps will reproduce the problem?
1. write in one of the input boxes something the application does not 
recognize, for example "one" for time, "Hell" for place, "psvx" for any field
2. nothing happens, the fields are in an inconsistent state

> What is the expected output? What do you see instead?
I would expect some kind of error message, or perhaps change of color of the 
field to indicate a problem, gray out the other fields to indicate they do not 
correspond to the current input, or something similar.

> What version of the product are you using? On what operating system?
Whatever is online now.

Original issue reported on code.google.com by ondrej.m...@gmail.com on 1 Jun 2011 at 10:02

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 14, 2015

Ah, OK, color indication is there, but it's rather subtle. Still, the following 
exists:

1) enter "x" in first two fields
2) change last field to a valid place
3) observe that third field updates, corresponding to something unknown/unclear

Original comment by ondrej.m...@gmail.com on 1 Jun 2011 at 10:05

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 14, 2015

Great point, thanks! I will make the "valid color" more prominent. I'm not sure 
what to do with the "x" use case. Hopefully with the invalidity more visible, 
it won't be that confusing.

Original comment by filip.hr...@gmail.com on 2 Jun 2011 at 8:07

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 14, 2015

Change #eeffee -> #d0f9d5.

Original comment by filip.hr...@gmail.com on 2 Jun 2011 at 10:33

@GoogleCodeExporter
Copy link
Author

GoogleCodeExporter commented Mar 14, 2015

Color now more prominent. So is the highlight.

Original comment by filiph@google.com on 3 Jun 2011 at 3:14

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant