-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow modifying/disabling keyboard shortcut for toggling icon bar #177
Comments
Allowing users to modify a keyboard shortcut (without them having to modify the code) could add quite a lot of complexity to the code due to how it's currently implemented. I'm also not sure about optionally disabling it as it also adds a bit of additional complexity with additional preference. However, I can change the shortcut to only trigger once all keys have been released and only if only Ctrl and Alt keys have been pressed. This way, the icon bar shouldn't toggle on your Ctrl+Alt+<arrow key> shortcuts. I hope that would be enough, but I can probably still implement a preference to disable that shortcut if needed. |
That would probably be enough for my needs although it would still be nice to be able to disable the shortcut with a preference. |
Perhaps I should create a new issue but after the update to 2.0.1, I can no longer hide the icon bar at all. If I right-click on the bar and deselect "Icon Bar" or press Ctrl+Alt, it shows as deselected in the right-click menu but the bar is still visible. |
It works for me... Can you check if |
I tried creating a new PWA in a new profile and enabled |
Sorry, I also tried hiding it from the 'Customize Toolbar" page as well. |
Yeah, please create a new issue, and also specify which OS and dektop environment you use. |
Problem Description
Currently if you have enabled a hiding icon bar (by setting the config option
firefoxpwa.enableHidingIconBar = true
), the only keyboard shortcut to toggle this is Ctrl+Alt.Proposed Solution
It would be nice if this keyboard shortcut could be modified or disabled (the icon bar can still be toggled by right-clicking the title bar).
Additional Information
I guess it's my fault but I use Ctrl+Alt+<arrow key> to navigate between desktops so often find myself toggling the icon bar on my firefox PWAs accidentally.
The text was updated successfully, but these errors were encountered: