Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reopening a PWA after closing all windows opens new tab page #42

Closed
TitanNano opened this issue Aug 5, 2021 · 4 comments
Closed

reopening a PWA after closing all windows opens new tab page #42

TitanNano opened this issue Aug 5, 2021 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@TitanNano
Copy link
Contributor

Description

Steps to Reproduce

  1. Open a PWA
  2. close all windows of the application
  3. click on the dock icon of the PWA

Expected Behavior

A new window of the PWA is opened.

Actual Behavior

A new window with the Firefox new tab / home page is opened. There is also no way to get into the PWA anymore and the app has to be closed and restarted.

Additional Information

Environment

  • Operating system: macOS

  • System architecture: x64

  • Installation method: from source

  • Firefox version: 90.0.2

  • FirefoxPWA extension version: 0.5.0

  • FirefoxPWA native version: 0.5.0

@TitanNano TitanNano added the bug Something isn't working label Aug 5, 2021
@dithom
Copy link

dithom commented Sep 20, 2021

Same here, a fix would be awesome!

@DabeDotCom
Copy link

I don't know how hard it would be to roll into a proper "fix", but my naïve† workaround was to update the browser.startup.homepage setting in about:config to be the same as the start_url page of the PWA:

  1. Open the app's Preferences (e.g., ⌘ Comma on a Mac)
  2. While the Preferences page is displayed, open "Developer Tools » Console" (⌘⌥ K)
  3. In the console, type: document.location.href="about:config" and hit Enter
  4. Accept the Risk
  5. Type home into the Search Box, then change the value of the browser.startup.homepage field from about:home to the URL of your PWA and hit Enter

Et voilà! Close the window/tab (⌘ W) and re-open a new one (⌘ N or ⌘ T) and it should launch your app from now on, rather than showing the Firefox "about:home" page...

† PS — It goes without saying, of course, that this is all likely unsupported: YMMV; use at your own risk; void where prohibited; not applicable in New Hampshire; etc. ;-D

@filips123
Copy link
Owner

filips123 commented Jun 22, 2022

Well, at least that workaround is better than nothing. I will try to check how Firefox handles this internally, but if I don't find anything easy and useful, I will just implement setting homepage URL when you launch a PWA.

It might not work when multiple PWAs are in the same profile, but they already don't work properly on macOS (#81) and users should install each into own profile, so I guess it's fine.

@filips123 filips123 added this to the 2.0.0 milestone Jun 22, 2022
@filips123
Copy link
Owner

I implemented a fix/workaround for this which will be released in 2.0.0. However, it still doesn't work when multiple PWAs are in the same profile. This does not matter currently as multiple PWAs per profile should not be used because of #81, but once it is fixed, this also needs to be reworked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants