New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_get_contents([internal]): failed to open stream: No such file or directory #598

Closed
lcharette opened this Issue Oct 21, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@lcharette

lcharette commented Oct 21, 2018

We're encountering a file_get_contents([internal]): failed to open stream: No such file or directory error in our implementation of whoops. After some digging, it goes back to the changes made in 4798f07.

The [internal] part is returned by the Inspector. Removing the superfluous is_file() check doesn't really make sense if a file can be set as [internal] and won't be catched by the other checks.

A proposed fix would be to revert changes made in 4798f07.

lcharette added a commit to userfrosting/UserFrosting that referenced this issue Oct 21, 2018

Locked Whoops to version 2.2.1
...until they fix that `[internal]` issue 
filp/whoops#598
@staabm

This comment has been minimized.

Contributor

staabm commented Oct 21, 2018

Can you describe how to reproduce this problem?

@lcharette

This comment has been minimized.

lcharette commented Oct 21, 2018

This is the test that was failing based on our integration of Whoops in UserFrosting : https://github.com/userfrosting/UserFrosting/blob/master/app/sprinkles/core/tests/Integration/Error/Renderer/WhoopsRendererTest.php

I'll see if I can replicate using vanilla Whoops.

@lcharette

This comment has been minimized.

lcharette commented Oct 21, 2018

I managed to replicate in a fresh clone of this repo by changing this line : https://github.com/filp/whoops/blob/master/tests/Whoops/Handler/PrettyPageHandlerTest.php#L21

To :

$handler->handleUnconditionally(true);

Same happens if you change the default property to true (private $handleUnconditionally = true;)

@staabm

This comment has been minimized.

Contributor

staabm commented Oct 21, 2018

Thanks, will investigate

@denis-sokolov

This comment has been minimized.

Collaborator

denis-sokolov commented Oct 23, 2018

Fixed in #599!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment