Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kebab the public interface #29

Closed
jonathanstowe opened this issue May 19, 2016 · 5 comments
Closed

Kebab the public interface #29

jonathanstowe opened this issue May 19, 2016 · 5 comments

Comments

@jonathanstowe
Copy link
Contributor

Parts of the public interface are using snake_case while I have been adding the new stuff with kebab-case, obviously consistency would be better and I think that the consensus has largely converged on using kebab-case in new code.

Obviously this would be an in-compatible change so there would need to be a short deprecation cycle (though as it currently stands the module isn't properly versioned so this in itself is somewhat problematic,)

I'll leave this for discussion for a bit before I do anything.

@jnthn
Copy link

jnthn commented May 19, 2016

Consistency is the key thing, whichever way it goes. I'd be happy enough if it consistently used kebab-case; it seems to be what many things are settling on.

@finanalyst
Copy link
Owner

I've just started to work on a GTK::Simple::RadioGroup widget.
The idea is to take a list of labels and create a group of radio buttons and MarkUpLabels. Toggle interaction would return a single integer referring to the button in the group. This is not entirely the same as a GTK RadioGroup.
I'll need some time to finish this, and send it for review. Just letting you know, I need this Widget for another project.

@jonathanstowe
Copy link
Contributor Author

Cool. I'm working on a couple of things but it shouldn't get in your way, I'll probably get the #28 in today which you might want to bear in mind, but it won''t stop you doing what you want to do.

@jonathanstowe
Copy link
Contributor Author

I've done #28 now, so you may want to merge the current master before proceeding. Hopefully the way that the property facade I have implemented works is clear enough without any further explanation, if not give me a shout.

@jonathanstowe
Copy link
Contributor Author

To go back to the original question, there are only 10 public methods that are named in snake case - I'm minded to rename and deprecate the old names without further ado.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants