New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs, add prereq & strict #36

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bpa

bpa commented Dec 24, 2015

Update doc and README to reflect change to use Dist::Zilla
Add strict on two modules to pass Kwalitee test
Add test prerequisite to dist.ini

Add strict to remove Kwalitee fail
Update doc and README to reflect change to use Dist::Zilla
@ecocode

This comment has been minimized.

Show comment
Hide comment
@ecocode

ecocode Feb 2, 2016

Contributor

thanks!

Can you specify any reason why you added :

[Prereqs / TestRequires]
HTML::TableExtract = 0

Since we already added AutoPrereqs this dependency should be auto detected..

Contributor

ecocode commented Feb 2, 2016

thanks!

Can you specify any reason why you added :

[Prereqs / TestRequires]
HTML::TableExtract = 0

Since we already added AutoPrereqs this dependency should be auto detected..

@bpa

This comment has been minimized.

Show comment
Hide comment
@bpa

bpa Feb 2, 2016

I think I must have using dzil wrong at first and thought it wasn't picking
it up. I'm seeing HTML::TableExtract in dzil listdeps without that
change.

I also forgot to mention this was part of the 2015 Pull Request Challenge.
I hadn't used Dist::Zilla before checking this out. No Makefile.PL threw
me at first, but cpan and cpanm have no problems building for me.

On Tue, Feb 2, 2016 at 2:13 AM, Erik Colson notifications@github.com
wrote:

thanks!

Can you specify any reason why you added :

[Prereqs / TestRequires]
HTML::TableExtract = 0

Since we already added AutoPrereqs this dependency should be auto
detected..


Reply to this email directly or view it on GitHub
#36 (comment)
.

bpa commented Feb 2, 2016

I think I must have using dzil wrong at first and thought it wasn't picking
it up. I'm seeing HTML::TableExtract in dzil listdeps without that
change.

I also forgot to mention this was part of the 2015 Pull Request Challenge.
I hadn't used Dist::Zilla before checking this out. No Makefile.PL threw
me at first, but cpan and cpanm have no problems building for me.

On Tue, Feb 2, 2016 at 2:13 AM, Erik Colson notifications@github.com
wrote:

thanks!

Can you specify any reason why you added :

[Prereqs / TestRequires]
HTML::TableExtract = 0

Since we already added AutoPrereqs this dependency should be auto
detected..


Reply to this email directly or view it on GitHub
#36 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment