Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent false positives in font detection in Tor Browser #159

Merged
merged 1 commit into from May 26, 2016

Conversation

Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@arthuredelstein
Copy link
Contributor

@arthuredelstein arthuredelstein commented May 26, 2016

I discovered (OS X) that fingerprintjs2 reports a number of fonts in Tor Browser that are not actually present on the system. These false-positive fonts all have names containing a space and a numeral:
"Wingdings 2","Wingdings 3","Bauhaus 93","Bodoni 72","Bodoni 72 Oldstyle","Bodoni 72 Smallcaps","Bookshelf Symbol 7","English 111 Vivace BT","GeoSlab 703 Lt BT","GeoSlab 703 XBd BT","Humanst 521 Cn BT","Modern No. 20","Univers CE 55 Medium".

I found that adding quotes around the fontToDetect in the style.fontFamily attribute prevents the font from being falsely detected.

@Valve
Copy link
Member

@Valve Valve commented May 26, 2016

Nice catch!
Thanks, will test & merge over the weekend

@Valve Valve merged commit 1321be2 into fingerprintjs:master May 26, 2016
1 check passed
@Valve
Copy link
Member

@Valve Valve commented May 26, 2016

This fixed the false positives everywhere, not only in Tor, thanks!
released v1.3.0 with your fix

@arthuredelstein
Copy link
Contributor Author

@arthuredelstein arthuredelstein commented May 26, 2016

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment