-
Notifications
You must be signed in to change notification settings - Fork 73
Allow bootstrapping on 10.14.5 w/ perl 5.18.4 #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems sensible to me. |
Bootstrap worked for me (10.14.5/Xcode 10.2) Fionna:fink hansen$ /tmp/sw/bin/fink list perl |
I tried bootstrapping on 10.14.6 with this and get a failure:
|
@mrvacbob was this a fresh bootstrap, or an update of an existing install? |
This is a fresh bootstrap from the |
What does 10.14.6 report with |
|
@mrvacbob, @nieder, that's probably due to what @PovlAbrahamsen noted above, because when the tests fail they fall through to 10.14 instead of 10.14.5. |
…value until proven otherwise.
648179b should take care of unreleased versions accidentally falling back to Dist: 10.14 and not 10.14.5. However, I think line 260 in Engine.pm needs to be tweaked because I think I hardcoded it to only work as intended when 10.14.5 (distribution field) == 10.14.5 (os version). And I don't know enough perl to grok the versions correctly as version numbers and not as strings or decimals. |
version->parse() is what is used to convert the strings/decimals into version strings. |
That conditional is driving me nuts.
(2) is meant to catch macOS 10.14.[67...], where $distribution = 10.14.5, but $osversion_long != 10.14.5. And the leading if for (2) is because we normally don't want to compare against $osversion_long, except in the 10.14.5 case. Does this make sense? |
To update, this worked for me as a both a fresh install (./bootstrap) on 10.14.5 and just tested an upgrade from 0.44.1 (./inject) on 10.14.5. Not tested on 10.14.6 but I think the pseudocode in m previous comment should work if someone could help with the actual perl code. |
I looked at this a bit, but I haven't gotten to the point of actual code yet--I've been doing paid job stuff over the weekend. |
Changes to Engine.pm to allow upgrades to 10.14.5 distribution
To install this work in progress Fink on a fresh Mac with 10.14.5
|
Where are we at on this? |
I've tested fresh installs on 10.14.5 and .6beta and updates from a previous 10.14.4 setup. Other people on the mailing lists have also reported success. |
Hey, I have been trying to download Fink to my Mac on 10.14.5 using the zip from nieder, but I keep getting an error with my dpkg files. I have attached the latest log from running bootstrap. I also tried
It says this whether I use git or rsync. I've tried searching the Mailing List but I thought I may have better luck on here in case it is something to do with nieder's compilation? |
@sclint13, the issue isn't with this patch, but with a separate copy of libz, which you appear to have installed in /usr/local/lib. This seems to be throwing off the linker, preventing it from linking to the system-installed libz in /usr/lib.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine by me.
Sorry, I pushed a couple more changes. I think I'm done doing that. |
I am a beginner to coding and was trying to install fink on a Mac OS 10.14.5 where I stumbled on the Perl error. I therefore used https://github.com/fink/fink/archive/nieder-5.18.4-bootstrap.zip and the installation was complete. However, when trying to launch fink, I get this error: _You should now have a working Fink installation in '/sw'. You still need package descriptions if you want Run '. /sw/bin/init.sh' to set up this terminal session environment to use Fink. To make the software Jareds-MacBook-Pro:fink-nieder-5.18.4-bootstrap jaredokiro$ /sw/bin/init.sh Kindly assist. Thanks._ |
You need to run ". /sw/bin/init.sh" - note the period and space before "/sw/bin/init.sh". |
Thanks. It works now:) |
Not all seems perfect, as shown by trying to install package: So..., as pasted from the terminal under tcsh: |
@peytondh that's an independent issue. |
akhansen: |
My point is that those have nothing to do with the fink code itself. Those are covered in the Fink distribution repository (fink/fink-distributions). Basically, nothing that goes on here in this repository will address that. |
Thanks, and forgive my ignorance about devision of responsibilities. I just wanted to let people know about the issue, so that the right people could address it. |
@peytondh Package changes for 10.14.5 are tracked in fink/fink-distributions#423 |
Confirmed. Works. Thanks to all! |
No description provided.