{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":609186884,"defaultBranch":"main","name":"atlantis","ownerLogin":"finnag","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-03-03T15:00:57.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/497561?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1714055473.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"2b44cc68e4bec94b001e36a9bda0176ec2875b4e","ref":"refs/heads/cog2","pushedAt":"2024-04-25T14:31:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"only update policycheck/apply status on plan, not draftplan","shortMessageHtmlLink":"only update policycheck/apply status on plan, not draftplan"}},{"before":"74cc57d74c7a3923ca3ec0014026315ad8e93236","after":"69b5c6aa8884f59b564257abae85c897555454f0","ref":"refs/heads/remove-recursion-module-load","pushedAt":"2024-04-25T14:07:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"remove recursion from moduleInfo.load()\n\nmoduleInfo.load() used to load modules and depdencies recursively,\nand due to some unfortunate circumstances it would usually create a\nvery deep call stack where each load() called another load() to load\nthe next one.\n\nThe terraform parsing uses enough stack space that this can become a\nproblem, so for a slightly big project this sometimes caused atlantis\nto die from a stack overflow:\n\nruntime: goroutine stack exceeds 1000000000-byte limit\nruntime: sp=0xc021478380 stack=[0xc021478000, 0xc041478000]\nfatal error: stack overflow\n[...]\ngithub.com/runatlantis/atlantis/server/events.moduleInfo.load(...)\n\t...atlantis/server/events/modules.go:108 +0x46b fp=0xc021478750 sp=0xc021478570 pc=0xfeaa6b\ngithub.com/runatlantis/atlantis/server/events.moduleInfo.load(...)\n\t...atlantis/server/events/modules.go:108 +0x46b fp=0xc021478930 sp=0xc021478750 pc=0xfeaa6b\ngithub.com/runatlantis/atlantis/server/events.moduleInfo.load(...)\n\t...atlantis/server/events/modules.go:108 +0x46b fp=0xc021478b10 sp=0xc021478930 pc=0xfeaa6b\n\n... and so on, several hundred times.","shortMessageHtmlLink":"remove recursion from moduleInfo.load()"}},{"before":"4d89a78a1f89165fd917d9c24a2f74158dc8071a","after":null,"ref":"refs/heads/paralle-plans","pushedAt":"2024-04-25T14:04:11.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"}},{"before":"d69ff5a8fae61ee871cc87b59ca1f214911af7a1","after":"4d89a78a1f89165fd917d9c24a2f74158dc8071a","ref":"refs/heads/parallel-plans","pushedAt":"2024-04-25T14:03:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"refactor: split Clone into Clone and MergeAgain\n\nClone is now a NOP if the PR has not changed, and loses its second\nreturn value, the MergedAgain flag.\n\nMergeAgain must be called explicitly in the only location that\ncares about this flag, just before planning.\n\nThis cleans up the code for Clone and re-merging a bit.\n\nAlso regenerated mocks","shortMessageHtmlLink":"refactor: split Clone into Clone and MergeAgain"}},{"before":null,"after":"4d89a78a1f89165fd917d9c24a2f74158dc8071a","ref":"refs/heads/paralle-plans","pushedAt":"2024-04-25T14:03:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"refactor: split Clone into Clone and MergeAgain\n\nClone is now a NOP if the PR has not changed, and loses its second\nreturn value, the MergedAgain flag.\n\nMergeAgain must be called explicitly in the only location that\ncares about this flag, just before planning.\n\nThis cleans up the code for Clone and re-merging a bit.\n\nAlso regenerated mocks","shortMessageHtmlLink":"refactor: split Clone into Clone and MergeAgain"}},{"before":null,"after":"2488b87d6308f1fa13587956e1a8d2e9126a370d","ref":"refs/heads/finnag/quickplan","pushedAt":"2024-04-25T12:45:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"PlanStatus needs to handle DraftPlan as well","shortMessageHtmlLink":"PlanStatus needs to handle DraftPlan as well"}},{"before":"f2e65c022c081e0dd5cebdb1e2d3f1b752209d2d","after":"74cc57d74c7a3923ca3ec0014026315ad8e93236","ref":"refs/heads/remove-recursion-module-load","pushedAt":"2024-02-26T17:58:51.000Z","pushType":"push","commitsCount":122,"pusher":{"login":"jamengual","name":"PePe Amengual","path":"/jamengual","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2208324?s=80&v=4"},"commit":{"message":"Merge branch 'main' into remove-recursion-module-load","shortMessageHtmlLink":"Merge branch 'main' into remove-recursion-module-load"}},{"before":"11dd8a15ee195a81696ed6cbf6c96e0d2eeb32ac","after":"f1ccc98dfbbca9033e723e379d1c8c5772990f09","ref":"refs/heads/use-standard-mock-fn","pushedAt":"2023-12-12T00:29:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"GenPage","name":"Dylan Page","path":"/GenPage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3201853?s=80&v=4"},"commit":{"message":"refactor: regen mocks, use existing VerifyWasCalled(Never())","shortMessageHtmlLink":"refactor: regen mocks, use existing VerifyWasCalled(Never())"}},{"before":"cbbad7b1e6ec638e290768ac7da47e65421e8a3b","after":"11dd8a15ee195a81696ed6cbf6c96e0d2eeb32ac","ref":"refs/heads/use-standard-mock-fn","pushedAt":"2023-12-12T00:26:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"GenPage","name":"Dylan Page","path":"/GenPage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3201853?s=80&v=4"},"commit":{"message":"refactor: regen mocks, use existing VerifyWasCalled(Never())","shortMessageHtmlLink":"refactor: regen mocks, use existing VerifyWasCalled(Never())"}},{"before":"49f3389963ef0f79cf4f6d66e1568d3f8bd8a011","after":"ced9146400aa991966367031e447fbdef4593bd2","ref":"refs/heads/policycheck-success-on-no-projects","pushedAt":"2023-12-11T18:48:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"GenPage","name":"Dylan Page","path":"/GenPage","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3201853?s=80&v=4"},"commit":{"message":"set policy_check status to success when no changes\n\nAutoplan would set the \"policy_check\" status to successful if\nthere were no modified projects in a PR, but \"atlantis plan\"\nwould not. Changed \"atlantis plan\" to behave like autoplan\nin this regard.","shortMessageHtmlLink":"set policy_check status to success when no changes"}},{"before":"e836a1b18eafccad573bffe5b171fcf54a9ce1ad","after":"cbbad7b1e6ec638e290768ac7da47e65421e8a3b","ref":"refs/heads/use-standard-mock-fn","pushedAt":"2023-11-15T07:08:13.000Z","pushType":"push","commitsCount":42,"pusher":{"login":"jamengual","name":"PePe Amengual","path":"/jamengual","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2208324?s=80&v=4"},"commit":{"message":"Merge branch 'main' into use-standard-mock-fn","shortMessageHtmlLink":"Merge branch 'main' into use-standard-mock-fn"}},{"before":"f95ff71cb3897a2793a74558d59152ad20ff2274","after":"49f3389963ef0f79cf4f6d66e1568d3f8bd8a011","ref":"refs/heads/policycheck-success-on-no-projects","pushedAt":"2023-11-15T06:31:47.000Z","pushType":"push","commitsCount":80,"pusher":{"login":"jamengual","name":"PePe Amengual","path":"/jamengual","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2208324?s=80&v=4"},"commit":{"message":"Merge branch 'main' into policycheck-success-on-no-projects","shortMessageHtmlLink":"Merge branch 'main' into policycheck-success-on-no-projects"}},{"before":"d0d9c4069ddd1c68acef0de747d848554057ceab","after":"f2e65c022c081e0dd5cebdb1e2d3f1b752209d2d","ref":"refs/heads/remove-recursion-module-load","pushedAt":"2023-11-15T06:30:51.000Z","pushType":"push","commitsCount":39,"pusher":{"login":"jamengual","name":"PePe Amengual","path":"/jamengual","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2208324?s=80&v=4"},"commit":{"message":"Merge branch 'main' into remove-recursion-module-load","shortMessageHtmlLink":"Merge branch 'main' into remove-recursion-module-load"}},{"before":"d0f8d096453b37cbe13c0a5ded1ef050c93740cf","after":"d69ff5a8fae61ee871cc87b59ca1f214911af7a1","ref":"refs/heads/parallel-plans","pushedAt":"2023-11-15T05:50:30.000Z","pushType":"push","commitsCount":40,"pusher":{"login":"jamengual","name":"PePe Amengual","path":"/jamengual","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2208324?s=80&v=4"},"commit":{"message":"Merge branch 'main' into parallel-plans","shortMessageHtmlLink":"Merge branch 'main' into parallel-plans"}},{"before":"bec14e88321250d66b50ac14c7c7e093da5822cc","after":"b691ab7fd8bd4e34b25e0aa308f29dbfe6942af6","ref":"refs/heads/quickplan","pushedAt":"2023-11-15T05:31:20.000Z","pushType":"push","commitsCount":44,"pusher":{"login":"jamengual","name":"PePe Amengual","path":"/jamengual","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2208324?s=80&v=4"},"commit":{"message":"Merge branch 'main' into quickplan","shortMessageHtmlLink":"Merge branch 'main' into quickplan"}},{"before":"b1c8484e7cc24e612ac00f1ebc696f4a5cf2e811","after":"d0d9c4069ddd1c68acef0de747d848554057ceab","ref":"refs/heads/remove-recursion-module-load","pushedAt":"2023-10-16T19:40:00.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"chenrui333","name":"Rui Chen","path":"/chenrui333","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1580956?s=80&v=4"},"commit":{"message":"Merge branch 'main' into remove-recursion-module-load","shortMessageHtmlLink":"Merge branch 'main' into remove-recursion-module-load"}},{"before":null,"after":"e836a1b18eafccad573bffe5b171fcf54a9ce1ad","ref":"refs/heads/use-standard-mock-fn","pushedAt":"2023-10-16T09:57:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"refactor: regen mocks, use existing VerifyWasCalled(Never())","shortMessageHtmlLink":"refactor: regen mocks, use existing VerifyWasCalled(Never())"}},{"before":"580ea234c9b0925d3c914846efd2d628124280db","after":"d0f8d096453b37cbe13c0a5ded1ef050c93740cf","ref":"refs/heads/parallel-plans","pushedAt":"2023-10-16T09:27:54.000Z","pushType":"push","commitsCount":40,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"Merge branch 'main' into parallel-plans","shortMessageHtmlLink":"Merge branch 'main' into parallel-plans"}},{"before":"bdd553842d1ab09ac397227da2b7cd8007c8bc5f","after":"bec14e88321250d66b50ac14c7c7e093da5822cc","ref":"refs/heads/quickplan","pushedAt":"2023-10-13T12:54:04.000Z","pushType":"push","commitsCount":36,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"Merge branch 'main' into quickplan","shortMessageHtmlLink":"Merge branch 'main' into quickplan"}},{"before":"75c7b2309270d0179895ac4030685c5e03a89571","after":"b1c8484e7cc24e612ac00f1ebc696f4a5cf2e811","ref":"refs/heads/remove-recursion-module-load","pushedAt":"2023-10-13T12:51:33.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"Merge branch 'main' into remove-recursion-module-load","shortMessageHtmlLink":"Merge branch 'main' into remove-recursion-module-load"}},{"before":"d611606a2065ff28f764ad5c00ea489420114d8a","after":"75c7b2309270d0179895ac4030685c5e03a89571","ref":"refs/heads/remove-recursion-module-load","pushedAt":"2023-10-10T01:21:33.000Z","pushType":"push","commitsCount":28,"pusher":{"login":"jamengual","name":"PePe Amengual","path":"/jamengual","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2208324?s=80&v=4"},"commit":{"message":"Merge branch 'main' into remove-recursion-module-load","shortMessageHtmlLink":"Merge branch 'main' into remove-recursion-module-load"}},{"before":"d6340b984b61bd259d362fa081fa76817b852e9e","after":"580ea234c9b0925d3c914846efd2d628124280db","ref":"refs/heads/parallel-plans","pushedAt":"2023-09-29T11:50:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"refactor: split Clone into Clone and MergeAgain\n\nClone is now a NOP if the PR has not changed, and loses its second\nreturn value, the MergedAgain flag.\n\nMergeAgain must be called explicitly in the only location that\ncares about this flag, just before planning.\n\nThis cleans up the code for Clone and re-merging a bit.","shortMessageHtmlLink":"refactor: split Clone into Clone and MergeAgain"}},{"before":"a8a637cb252d2e81190a2c9fb79a4d1b9b925368","after":"d099cfeb58ed7d007bb9414ebe59cef52d522ccf","ref":"refs/heads/parallel-plans-mk2","pushedAt":"2023-09-29T11:38:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"refactor: split Clone into Clone and MergeAgain\n\nClone is now a NOP if the PR has not changed. MergeAgain is called just\nbefore planning, and only then, to merge again with upstream when\nusing the merge ceckout strategy.\n\nThis cleans up the code for Clone a bit.","shortMessageHtmlLink":"refactor: split Clone into Clone and MergeAgain"}},{"before":null,"after":"9200d0acf9e5a031cd5de96ef41ed0186461e0e6","ref":"refs/heads/fix-go-generate","pushedAt":"2023-09-29T09:53:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"Regenerate all mocks with make go-generate\n\nThe mocks now work without further modification after running go-generate.","shortMessageHtmlLink":"Regenerate all mocks with make go-generate"}},{"before":null,"after":"a8a637cb252d2e81190a2c9fb79a4d1b9b925368","ref":"refs/heads/parallel-plans-mk2","pushedAt":"2023-09-27T13:48:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"simplify clone and mergeAgain now that they only do one thing","shortMessageHtmlLink":"simplify clone and mergeAgain now that they only do one thing"}},{"before":"3244d82af3a9cdb1895f78ecd74d5d3b7f88316f","after":"f95ff71cb3897a2793a74558d59152ad20ff2274","ref":"refs/heads/policycheck-success-on-no-projects","pushedAt":"2023-09-27T10:09:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"set policy_check status to success when no changes\n\nAutoplan would set the \"policy_check\" status to successful if\nthere were no modified projects in a PR, but \"atlantis plan\"\nwould not. Changed \"atlantis plan\" to behave like autoplan\nin this regard.","shortMessageHtmlLink":"set policy_check status to success when no changes"}},{"before":"da1373fb40bc90519568181373298d00e37e390c","after":null,"ref":"refs/heads/safer-re-merge","pushedAt":"2023-09-27T10:07:41.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"}},{"before":"39b2a011253638941764ab2641c9a005c68c164a","after":"d611606a2065ff28f764ad5c00ea489420114d8a","ref":"refs/heads/remove-recursion-module-load","pushedAt":"2023-09-27T09:59:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"remove recursion from moduleInfo.load()\n\nmoduleInfo.load() used to load modules and depdencies recursively,\nand due to some unfortunate circumstances it would usually create a\nvery deep call stack where each load() called another load() to load\nthe next one.\n\nThe terraform parsing uses enough stack space that this can become a\nproblem, so for a slightly big project this sometimes caused atlantis\nto die from a stack overflow:\n\nruntime: goroutine stack exceeds 1000000000-byte limit\nruntime: sp=0xc021478380 stack=[0xc021478000, 0xc041478000]\nfatal error: stack overflow\n[...]\ngithub.com/runatlantis/atlantis/server/events.moduleInfo.load(...)\n\t...atlantis/server/events/modules.go:108 +0x46b fp=0xc021478750 sp=0xc021478570 pc=0xfeaa6b\ngithub.com/runatlantis/atlantis/server/events.moduleInfo.load(...)\n\t...atlantis/server/events/modules.go:108 +0x46b fp=0xc021478930 sp=0xc021478750 pc=0xfeaa6b\ngithub.com/runatlantis/atlantis/server/events.moduleInfo.load(...)\n\t...atlantis/server/events/modules.go:108 +0x46b fp=0xc021478b10 sp=0xc021478930 pc=0xfeaa6b\n\n... and so on, several hundred times.","shortMessageHtmlLink":"remove recursion from moduleInfo.load()"}},{"before":"af24c99943ff5da4746886f2dc59b21c3662f58f","after":"39b2a011253638941764ab2641c9a005c68c164a","ref":"refs/heads/remove-recursion-module-load","pushedAt":"2023-09-27T09:58:34.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"Merge branch 'main' into remove-recursion-module-load","shortMessageHtmlLink":"Merge branch 'main' into remove-recursion-module-load"}},{"before":"e465e2e325626a918e70fa89e6b53ed4948e8085","after":"d6340b984b61bd259d362fa081fa76817b852e9e","ref":"refs/heads/parallel-plans","pushedAt":"2023-09-27T08:42:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"finnag","name":"Finn Arne Gangstad","path":"/finnag","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/497561?s=80&v=4"},"commit":{"message":"Reduce the number of git calls in parallel mode when merging\n\nAll Clone() calls that have signaled an interest in merging\nbefore another Clone() checks whether a merge is necessary\ncan skip their own checks.\n\nThis should reduce the thundering herd problem at the\nbeginning of large paralell runs.","shortMessageHtmlLink":"Reduce the number of git calls in parallel mode when merging"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEOkT4iAA","startCursor":null,"endCursor":null}},"title":"Activity · finnag/atlantis"}