New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this didn't detect as a csv #7

Open
karissa opened this Issue Aug 5, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@karissa
Collaborator

karissa commented Aug 5, 2015

Maybe a csv like this should pass? Just ran in to this with some real-world data while using dat

"name"
"finnp"
"karissa"
"mafintosh"
"albert"

@finnp finnp closed this in 862014d Aug 6, 2015

@finnp finnp reopened this Aug 6, 2015

@finnp

This comment has been minimized.

Show comment
Hide comment
@finnp

finnp Aug 6, 2015

Owner

I have just commited support for quoted strings. But I am thinking about also allowing other one-column csv like this

hello
1
2
3
4

However I am not exactly sure yet how to differentiate them from things like this

<xml>
what
</xml>
Owner

finnp commented Aug 6, 2015

I have just commited support for quoted strings. But I am thinking about also allowing other one-column csv like this

hello
1
2
3
4

However I am not exactly sure yet how to differentiate them from things like this

<xml>
what
</xml>
@karissa

This comment has been minimized.

Show comment
Hide comment
@karissa

karissa Aug 6, 2015

Collaborator

Yeah, good point. perhaps we could just close this and the consumer can
decide what to do if it returns null

On Thursday, August 6, 2015, Finn Pauls notifications@github.com wrote:

I have just commited support for quoted strings. But I am thinking about
also allowing other one-column csv like this

hello
1
2
3
4

However I am not exactly sure yet how to differentiate them from things
like this

what


Reply to this email directly or view it on GitHub
#7 (comment).

Karissa McKelvey
http://karissa.github.io/ http://karissamck.com

Send me an encrypted message:
https://keybase.io/karissa https://keybase.io/karissa/key.asc

Collaborator

karissa commented Aug 6, 2015

Yeah, good point. perhaps we could just close this and the consumer can
decide what to do if it returns null

On Thursday, August 6, 2015, Finn Pauls notifications@github.com wrote:

I have just commited support for quoted strings. But I am thinking about
also allowing other one-column csv like this

hello
1
2
3
4

However I am not exactly sure yet how to differentiate them from things
like this

what


Reply to this email directly or view it on GitHub
#7 (comment).

Karissa McKelvey
http://karissa.github.io/ http://karissamck.com

Send me an encrypted message:
https://keybase.io/karissa https://keybase.io/karissa/key.asc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment