Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash urls #123

Closed
gilesbradshaw opened this issue Jul 5, 2013 · 3 comments
Closed

hash urls #123

gilesbradshaw opened this issue Jul 5, 2013 · 3 comments
Milestone

Comments

@gilesbradshaw
Copy link
Collaborator

@gilesbradshaw gilesbradshaw commented Jul 5, 2013

I am obviously missing something here but my (very old) code had:
hp.bind = function () {
ko.applyBindingsToNode(this.element, {
attr: {
'href': pager.Href.hash + this.path()
}
});
};

but this is no longer in version 1. I found I had to add it back in to get the hash in my page-hrefs

finnsson added a commit that referenced this issue Jul 6, 2013
@finnsson
Copy link
Owner

@finnsson finnsson commented Jul 6, 2013

A bug managed to slip through. The code didn't correctly handle page-href: '/some/absolute/path'.

Could you test if it works for you now without the above fix?

@gilesbradshaw
Copy link
Collaborator Author

@gilesbradshaw gilesbradshaw commented Jul 10, 2013

ah ok I see what you have done. I have some 'special' bindinghandlers based on yours I've had to modify them and now have your code back to how it should be.

@finnsson
Copy link
Owner

@finnsson finnsson commented Jul 13, 2013

Fixed.

@finnsson finnsson closed this Jul 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.