pagerjs AMD support replies on global $ variable #135

huochunpeng opened this Issue Jul 19, 2013 · 1 comment


None yet

2 participants


Hi Finnsson,
The pager.js amd implementation relies on jQuery lib registers itself as the global variable "$", which is true by default. But developer may choose to use jQuery noConflict to turn off global variables "$" and "jQuery" to conform with the idea of AMD.

Should not this

define('pager', ['knockout', 'jquery'], function (ko) {
    return pagerJsModule($, ko);

be updated to

define('pager', ['knockout', 'jquery'], function (ko, $) { ... });


@finnsson finnsson closed this in 690386e Aug 1, 2013
finnsson commented Aug 1, 2013

Thanks for the bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment