New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagerjs AMD support replies on global $ variable #135

Closed
huochunpeng opened this Issue Jul 19, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@huochunpeng

huochunpeng commented Jul 19, 2013

Hi Finnsson,
The pager.js amd implementation relies on jQuery lib registers itself as the global variable "$", which is true by default. But developer may choose to use jQuery noConflict to turn off global variables "$" and "jQuery" to conform with the idea of AMD.
http://requirejs.org/docs/jquery.html#noconflictmap

Should not this

define('pager', ['knockout', 'jquery'], function (ko) {
    return pagerJsModule($, ko);
});

be updated to

define('pager', ['knockout', 'jquery'], function (ko, $) { ... });

?

@finnsson finnsson closed this in 690386e Aug 1, 2013

@finnsson

This comment has been minimized.

Show comment
Hide comment
@finnsson

finnsson Aug 1, 2013

Owner

Thanks for the bug report.

Owner

finnsson commented Aug 1, 2013

Thanks for the bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment