Should use getBaseUrl instead of getRootUrl in startHistoryJs #110

merged 2 commits into from Mar 23, 2013


None yet

2 participants


goTo(pager.Href5.history.getState().url.replace(pager.Href5.history.getRootUrl(), ''));
should be
goTo(pager.Href5.history.getState().url.replace(pager.Href5.history.getBaseUrl(), ''));

Otherwise pager will not match the correct url when deployed under other context paths than the root

Same goes for History.Adapter.bind(window, 'statechange'...)

This pull request also fixes #108


Oups, both my commits ended up in this pull request.. I meant to split them up. Sorry about that.
I'll update the description with the additional commit.

@finnsson finnsson merged commit 32fb640 into finnsson:master Mar 23, 2013

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment