Do not overwrite nameParam on view model if it is already defined (fixes #100) #147

Merged
merged 1 commit into from Oct 19, 2013

Projects

None yet

2 participants

@alvingonzales
Contributor

Issue #100 seems to be due to augmentContext not properly checking if the viewmodel already has a property of the same name as nameParam. augmentContext overwrites it with a new observable, so old bindings relying on the old observable are not updated.

This fix checks if the viewmodel already has the property, and uses that instead.

@finnsson finnsson merged commit 00e7be5 into finnsson:master Oct 19, 2013

1 check passed

default The Travis CI build passed
Details
@finnsson
Owner

Thanks for the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment