New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite nameParam on view model if it is already defined (fixes #100) #147

Merged
merged 1 commit into from Oct 19, 2013

Conversation

Projects
None yet
2 participants
@alvingonzales
Contributor

alvingonzales commented Oct 14, 2013

Issue #100 seems to be due to augmentContext not properly checking if the viewmodel already has a property of the same name as nameParam. augmentContext overwrites it with a new observable, so old bindings relying on the old observable are not updated.

This fix checks if the viewmodel already has the property, and uses that instead.

finnsson added a commit that referenced this pull request Oct 19, 2013

Merge pull request #147 from alvingonzales/master
Do not overwrite nameParam on view model if it is already defined (fixes #100)

@finnsson finnsson merged commit 00e7be5 into finnsson:master Oct 19, 2013

1 check passed

default The Travis CI build passed
Details
@finnsson

This comment has been minimized.

Show comment
Hide comment
@finnsson

finnsson Oct 19, 2013

Owner

Thanks for the pull request.

Owner

finnsson commented Oct 19, 2013

Thanks for the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment